Chosen does not work on Multi-Select fields where Unlimited values are allowed. [#2079255]

First, I have to say this is by far the best select widget that I have used. Thank you for all of your hard work.

I have a select field that allows unlimited values and Chosen configured to auto apply on all multi-select fields. When the field has "Unlimited" values set, the field shows no options to choose from when clicking in the field.

However, on that same field, the moment I set it to 10 values, it works without problems.

Thanks in advance for any help.

Comment	File	Size	Author
#8	multi-select-unlim-2079255.patch	2.14 KB	azovsky
#8
#5	chosen-unlimited-cardinality-2079255-5.patch	1.4 KB	jdidelet
#5
#4	chosen-missing-test-multiple-property-2079255-4.patch	550 bytes	jdidelet
#4

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

NWOM CreditAttribution: NWOM commented 2 September 2013 at 08:36

I also get the following error message on the node add page. Maybe it has something to do with the same problem:

Notice: Undefined index: #multiple in chosen_pre_render_select() (line 182 of C:\inetpub\wwwroot\sites\all\modules\chosen\chosen.module).

Comment #2

patrickroma CreditAttribution: patrickroma commented 2 September 2013 at 14:50

Same here...

Comment #3

patrickroma CreditAttribution: patrickroma commented 2 September 2013 at 14:50

Same here...

Comment #4

jdidelet CreditAttribution: jdidelet commented 4 September 2013 at 02:39

Status:

Active

» Needs review

File	Size
chosen-missing-test-multiple-property-2079255-4.patch	550 bytes

patch attached for error related to #multiple

Comment #5

jdidelet CreditAttribution: jdidelet commented 4 September 2013 at 04:54

File	Size
chosen-unlimited-cardinality-2079255-5.patch	1.4 KB

attached new patch who resolve both problems.

Comment #6

Hydra CreditAttribution: Hydra commented 4 September 2013 at 12:18

Status:

Needs review

» Fixed

Well I'm not very happy with this solution. In the near future there will be a whole lot of configurable options introduced by #2076813: Move library options (configuration) to library plugin.
Anyway, till this is going to happen, I'm happy with this quickfix. Thanks for sharing the patch!
Pushed to 7.x-2.x http://drupalcode.org/project/chosen.git/commit/5ff10ed

Comment #7

jdidelet CreditAttribution: jdidelet commented 4 September 2013 at 14:39

Ah yes sorry. I probably didn't do in the most efficient way because I'm not aware of all of this for chosen module. It was just a quick patch to resolve this blocking point because I myself use this module for my projects. Anyway, thanks for your work on this module. I'll try to be more careful next time I'll submit a patch (or just mention it's a quick dirty patch :)).

Comment #8

azovsky CreditAttribution: azovsky commented 14 September 2013 at 16:03

Status:

Fixed

» Needs review

File	Size
multi-select-unlim-2079255.patch	2.14 KB

Fix from #5 breaks work of multi-selection (ability to select only one item) if on the page has other chosen fields.
So, here's my attempt to fix it in the patch.

Comment #9

NWOM CreditAttribution: NWOM commented 16 September 2013 at 08:51

Like what azvosky said, the fix then broke my Organic Groups audience widget. After applying fix #8 on top of the already committed patch, both problems have now been fixed. Thank you very much jdidelet and azovsky!