Remove Unused local variable from views_ui module

Part of meta-issue #2002650: [meta, no patch] improve maintainability by removing unused local variables

File /core/modules/views_ui/lib/Drupal/views_ui/Form/Ajax/ConfigItemGroup.php

Line 101: Unused local variable $id

Combine issues:

- #2080035: Remove Unused local variable $name from /core/modules/views_ui/lib/Drupal/views_ui/Form/Ajax/RearrangeFilter.php
- #2079891: Remove Unused local variable $name from /core/modules/views_ui/lib/Drupal/views_ui/Form/Ajax/Rearrange.php
- #2079881: Remove Unused local variable $stack from /core/modules/views_ui/lib/Drupal/views_ui/ViewUI.php

Comment	File	Size	Author
#21	drupal-core-remove-unused-local-variable-2080047-7.patch	2.35 KB	Alex Dicianu
#21
#16	drupal-core-remove-unused-local-variable-2080047-16.patch	2.35 KB	mrsinguyen
#16
#12	drupal-core-remove-unused-local-variable-2080047-5.patch	2.98 KB	mrsinguyen
#12
#11	drupal-core-remove-unused-local-variable-2080047-4.patch	2.63 KB	mrsinguyen
#11
#6	drupal-core-remove-unused-local-variable-2080047-3.patch	2.87 KB	mrsinguyen
#6
#5	drupal-core-remove-unused-local-variable-2080047-2.patch	5.09 KB	mrsinguyen
#5
#4	drupal-core-remove-unused-local-variable-1-2080047.patch	725 bytes	mrsinguyen
#4
#1	drupal-core-remove-unused-local-variable-2080047.patch	732 bytes	mrsinguyen
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

mrsinguyen CreditAttribution: mrsinguyen commented 3 September 2013 at 08:11

Status:

Active

» Needs review

File	Size
drupal-core-remove-unused-local-variable-2080047.patch	732 bytes

Attached patch.

Log in or register to post comments

Comment #2

3 September 2013 at 09:55

Status:	Needs review	» Needs work
Issue tags:	-Novice

The last submitted patch, drupal-core-remove-unused-local-variable-2080047.patch, failed testing.

Log in or register to post comments

Comment #3

mrsinguyen CreditAttribution: mrsinguyen commented 3 September 2013 at 12:07

Status:	Needs work	» Needs review
Issue tags:		+Novice

#1: drupal-core-remove-unused-local-variable-2080047.patch queued for re-testing.

Log in or register to post comments

Comment #4

mrsinguyen CreditAttribution: mrsinguyen commented 3 September 2013 at 12:15

File	Size
drupal-core-remove-unused-local-variable-1-2080047.patch	725 bytes

Just removed the unused variable.

Log in or register to post comments

Comment #5

mrsinguyen CreditAttribution: mrsinguyen commented 6 September 2013 at 13:05

File	Size
drupal-core-remove-unused-local-variable-2080047-2.patch	5.09 KB

Combine issue:

- #2080035: Remove Unused local variable $name from /core/modules/views_ui/lib/Drupal/views_ui/Form/Ajax/RearrangeFilter.php
- #2079891: Remove Unused local variable $name from /core/modules/views_ui/lib/Drupal/views_ui/Form/Ajax/Rearrange.php
- #2079881: Remove Unused local variable $stack from /core/modules/views_ui/lib/Drupal/views_ui/ViewUI.php

Log in or register to post comments

Comment #6

mrsinguyen CreditAttribution: mrsinguyen commented 6 September 2013 at 13:08

File	Size
drupal-core-remove-unused-local-variable-2080047-3.patch	2.87 KB

Above wrong because include SearchAdvancedSearchFormTest.php

Log in or register to post comments

Comment #7

mrsinguyen CreditAttribution: mrsinguyen commented 6 September 2013 at 13:10

Title:

Remove Unused local variable $id from /core/modules/views_ui/lib/Drupal/views_ui/Form/Ajax/ConfigItemGroup.php

» Remove Unused local variable from views_ui module

Log in or register to post comments

Comment #7.0

mrsinguyen CreditAttribution: mrsinguyen commented 6 September 2013 at 13:10

Issue summary:

Updated

Log in or register to post comments

Comment #8

6 September 2013 at 14:46

Status:	Needs review	» Needs work
Issue tags:	-Novice

The last submitted patch, drupal-core-remove-unused-local-variable-2080047-3.patch, failed testing.

Log in or register to post comments

Comment #9

mrsinguyen CreditAttribution: mrsinguyen commented 6 September 2013 at 15:03

Status:

Needs work

» Needs review

#6: drupal-core-remove-unused-local-variable-2080047-3.patch queued for re-testing.

Log in or register to post comments

Comment #10

6 September 2013 at 16:41

Status:	Needs review	» Needs work
Issue tags:		+Novice

The last submitted patch, drupal-core-remove-unused-local-variable-2080047-3.patch, failed testing.

Log in or register to post comments

Comment #11

mrsinguyen CreditAttribution: mrsinguyen commented 7 September 2013 at 03:57

Status:

Needs work

» Needs review

File	Size
drupal-core-remove-unused-local-variable-2080047-4.patch	2.63 KB

Log in or register to post comments

Comment #12

mrsinguyen CreditAttribution: mrsinguyen commented 7 September 2013 at 04:32

File	Size
drupal-core-remove-unused-local-variable-2080047-5.patch	2.98 KB

Added correct patch.

Log in or register to post comments

Comment #13

LinL CreditAttribution: LinL commented 25 September 2013 at 08:29

Status:	Needs review	» Needs work
Issue tags:		+Needs reroll

Patch no longer applies.

Log in or register to post comments

Comment #14

mrsinguyen CreditAttribution: mrsinguyen commented 25 September 2013 at 10:18

Status:	Needs work	» Needs review
Issue tags:	-Novice, -Needs reroll

#12: drupal-core-remove-unused-local-variable-2080047-5.patch queued for re-testing.

Log in or register to post comments

Comment #15

25 September 2013 at 10:21

Status:	Needs review	» Needs work
Issue tags:		+Novice, +Needs reroll

The last submitted patch, drupal-core-remove-unused-local-variable-2080047-5.patch, failed testing.

Log in or register to post comments

Comment #16

mrsinguyen CreditAttribution: mrsinguyen commented 25 September 2013 at 11:34

File	Size
drupal-core-remove-unused-local-variable-2080047-16.patch	2.35 KB

Log in or register to post comments

Comment #17

mrsinguyen CreditAttribution: mrsinguyen commented 25 September 2013 at 11:54

Status:

Needs work

» Needs review

Log in or register to post comments

mcrittenden’s picture

Comment #18

mcrittenden CreditAttribution: mcrittenden commented 1 October 2013 at 14:51

Issue tags:

Tags

Log in or register to post comments

tim.plunkett’s picture

Comment #19

he/him

English

Philadelphia

CreditAttribution: tim.plunkett commented 2 October 2013 at 19:40

Removing tags

Log in or register to post comments

Comment #20

LinL CreditAttribution: LinL commented 25 October 2013 at 09:29

Status:	Needs review	» Needs work
Issue tags:		+Needs reroll

Patch no longer applies, needs another reroll.

Log in or register to post comments

Alex Dicianu’s picture

Comment #21

Alex Dicianu CreditAttribution: Alex Dicianu commented 30 October 2013 at 11:05

Status:	Needs work	» Needs review
Issue tags:	-Needs reroll

File	Size
drupal-core-remove-unused-local-variable-2080047-7.patch	2.35 KB

This is my first re-roll attempt ever so please be gentle. Followed the instructions from here: https://drupal.org/patch/reroll

Log in or register to post comments

Alex Dicianu’s picture

Comment #21.0

Alex Dicianu CreditAttribution: Alex Dicianu commented 30 October 2013 at 11:05

Issue summary:

Updated issue summary.

Log in or register to post comments

Comment #22

German

CreditAttribution: dawehner commented 2 November 2013 at 09:35

Issue summary:	View changes
Status:	Needs review	» Reviewed & tested by the community

I checked the three files which are changed here and the proposed removals are fine.

Log in or register to post comments

Xano’s picture

Comment #23

Xano

he/they

English

Southampton

CreditAttribution: Xano commented 11 November 2013 at 08:11

21: drupal-core-remove-unused-local-variable-2080047-7.patch queued for re-testing.

Log in or register to post comments

Xano’s picture

Comment #24

Xano

he/they

English

Southampton

CreditAttribution: Xano commented 18 November 2013 at 07:43

21: drupal-core-remove-unused-local-variable-2080047-7.patch queued for re-testing.

Log in or register to post comments

Comment #25

he/him

English

CreditAttribution: catch commented 3 December 2013 at 12:15

Status:

Reviewed & tested by the community

» Fixed

Committed/pushed to 8.x, thanks!

Log in or register to post comments

Comment #26

17 December 2013 at 12:20

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Log in or register to post comments