Part of meta-issue #2002650: [meta] improve maintainability by removing unused local variables

File /core/modules/node/lib/Drupal/node/Tests/Views/FilterUidRevisionTest.php

Line 54: Unused local variable $node

Files: 
CommentFileSizeAuthor
#5 drupal_core-unused_local_variable-2080065-5.patch731 bytesPete B
PASSED: [[SimpleTest]]: [MySQL] 59,629 pass(es).
[ View ]
#3 drupal_core-unused_local_variable-2080065-3.patch1.4 KBPete B
FAILED: [[SimpleTest]]: [MySQL] 59,204 pass(es), 1 fail(s), and 1 exception(s).
[ View ]

Comments

Assigned:Unassigned» littledynamo

Status:Active» Needs review
StatusFileSize
new1.4 KB
FAILED: [[SimpleTest]]: [MySQL] 59,204 pass(es), 1 fail(s), and 1 exception(s).
[ View ]

None of the $node variables were being used.

Status:Needs review» Needs work

The last submitted patch, drupal_core-unused_local_variable-2080065-3.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new731 bytes
PASSED: [[SimpleTest]]: [MySQL] 59,629 pass(es).
[ View ]

Ok, so maybe they were used once or twice...

Thanks @Pete B for patch.

I have review and tested the patch its working fine for me.

Status:Needs review» Reviewed & tested by the community

Status:Reviewed & tested by the community» Fixed

Committed cddf217 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.