There's already a method setDebug() in maestro_base_engine.class.php and a private variable $this->_debug defined in maestro_engine_version1.php which seems to enable verbose watchdog logging. As far as I can see what's missing is the option to enable/disable debug mode in the admin ui at admin/config/workflow/maestro_configure. I suggest to introduce a new system settings variable maestro_debug_mode_enabled which may be configured through the admin ui.

Patch to follow.

CommentFileSizeAuthor
#3 maestro-debug-mode-2080111-3.patch1.99 KBlarskleiner
#1 maestro-debug-mode-2080111-1.patch1.62 KBlarskleiner
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

larskleiner’s picture

larskleiner CreditAttribution: larskleiner commented
FileSize
maestro-debug-mode-2080111-1.patch1.62 KB

Patch attached.

larskleiner’s picture

larskleiner CreditAttribution: larskleiner commented
Status: Active » Needs review

Changed status to "needs review"

larskleiner’s picture

larskleiner CreditAttribution: larskleiner commented
FileSize
maestro-debug-mode-2080111-3.patch1.99 KB

Re-rolled because I got the following notice with patch #1.

Notice: Undefined property: MaestroEngineVersion1::$mode in MaestroEngineVersion1->getQueue()

_randy’s picture

_randy CreditAttribution: _randy commented

Looks good too.. will commit.

_randy’s picture

_randy CreditAttribution: _randy commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 267e6fb on master, 8.x-1.x authored by larskleiner, committed by _randy: 
    Commit for addition of debug mode checkbox. Issue #2080111