Part of meta-issue #2002650: [meta] improve maintainability by removing unused local variables

File /core/modules/system/lib/Drupal/system/Tests/Plugin/CacheDecoratorLanguageTest.php

Line 68: Unused local variable $plugin_id
Line 81: Unused local variable $plugin_id
Line 89: Unused local variable $plugin_id
Line 111: Unused local variable $plugin_id
Line 116: Unused local variable $plugin_id

Files: 
CommentFileSizeAuthor
#8 drupal-core-remove-unused-variable-2080113-8.patch2.64 KBdeneo
PASSED: [[SimpleTest]]: [MySQL] 59,185 pass(es).
[ View ]
#6 2080113-remove-unused-variable-5.patch2.66 KBdeneo
FAILED: [[SimpleTest]]: [MySQL] 59,142 pass(es), 1 fail(s), and 0 exception(s).
[ View ]
#4 2080113-remove-unused-local-4.patch2.62 KBrhm50
PASSED: [[SimpleTest]]: [MySQL] 59,323 pass(es).
[ View ]

Comments

Status:Active» Closed (duplicate)

Status:Closed (duplicate)» Needs work

Status:Needs work» Active

This issue shouldn't have been closed - see https://drupal.org/node/2080311#comment-7909573.

Status:Active» Needs review
StatusFileSize
new2.62 KB
PASSED: [[SimpleTest]]: [MySQL] 59,323 pass(es).
[ View ]

Issue summary:View changes
Status:Needs review» Needs work

sorry, but I can't apply this patch..

Status:Needs work» Needs review
StatusFileSize
new2.66 KB
FAILED: [[SimpleTest]]: [MySQL] 59,142 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

patch

Status:Needs review» Needs work

The last submitted patch, 6: 2080113-remove-unused-variable-5.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new2.64 KB
PASSED: [[SimpleTest]]: [MySQL] 59,185 pass(es).
[ View ]

Status:Needs review» Reviewed & tested by the community

The patch applies cleanly and takes care of the issue. Thank you!

Status:Reviewed & tested by the community» Fixed

Committed/pushed to 8.x, thanks!

Status:Fixed» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.