Part of meta-issue #2002650: [meta, no patch] improve maintainability by removing unused local variables

File /core/modules/system/lib/Drupal/system/Tests/Database/CaseSensitivityTest.php

Line 28: Unused local variable $john

CommentFileSizeAuthor
#4 remove-unused-variable-john-2080291-4.patch715 bytesjustinchev
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

chertzog’s picture

chertzog
he/him
Primary language English
Location Harrisburg, PA, USA
CreditAttribution: chertzog commented
Status: Active » Closed (duplicate)

Closing as duplicate of #2080311: Clean up Drupal\system\Tests\Database\SelectTest.php

angel.h’s picture

angel.h
Primary language English
Location Plovdiv
CreditAttribution: angel.h commented
Status: Closed (duplicate) » Active

This issue shouldn't have been closed - see https://drupal.org/node/2080311#comment-7909573.

justinchev’s picture

justinchev CreditAttribution: justinchev commented
Assigned: Unassigned » justinchev
justinchev’s picture

justinchev CreditAttribution: justinchev commented
Status: Active » Needs review
FileSize
remove-unused-variable-john-2080291-4.patch715 bytes

Removed the '$john =' bit.

johnmcc’s picture

johnmcc CreditAttribution: johnmcc commented

#4 applies cleanly, and looks fine. The relevant test still passes too.

parthipanramesh’s picture

parthipanramesh CreditAttribution: parthipanramesh commented
Issue summary: View changes

Works as expected. Thank you!

parthipanramesh’s picture

parthipanramesh CreditAttribution: parthipanramesh commented
Status: Needs review » Reviewed & tested by the community
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.