Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of meta-issue #2002650: [meta, no patch] improve maintainability by removing unused local variables
File /core/tests/Drupal/Tests/Component/PhpStorage/MTimeProtectedFileStorageTest.php
Line 87: Unused local variable $storageFactory
Comment | File | Size | Author |
---|---|---|---|
#1 | drupal-core-remove-unused-local-variable-2080367.patch | 714 bytes | mrsinguyen |
Comments
Comment #1
mrsinguyen CreditAttribution: mrsinguyen commentedComment #2
YesCT CreditAttribution: YesCT commentedthis looks good: removes the var. phpstorm agrees it was unused and is ok without it. tests come back green. no extra changes.
still applies.
but will conflict with #1908440: Relax MTimeProtectedFileStorage permissions for DX, drush integration and world domination
[edit: wont conflict anymore, other issue is no longer removing it]
Comment #3
alexpottCommitted dd5b41b and pushed to 8.x. Thanks!