Part of meta-issue #2002650: [meta, no patch] improve maintainability by removing unused local variables

File /core/modules/locale/locale.pages.inc

Line 493: Unused local variable $project_id
Line 638: Unused local variable $id

CommentFileSizeAuthor
#1 drupal-core-remove-unused-local-variable-2080449.patch676 bytesmrsinguyen
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mrsinguyen’s picture

mrsinguyen CreditAttribution: mrsinguyen commented
Status: Active » Needs review
FileSize
drupal-core-remove-unused-local-variable-2080449.patch676 bytes

Attached patch.

boran’s picture

boran CreditAttribution: boran commented
Status: Needs review » Reviewed & tested by the community

The patch is a one liner, and looks good:
- grepped to look for $project_id, it is used in just one place in that file (i.e. limited to the scope of one function).
- its is set but never used.

- The patch applies cleanly and the variable is effectively removed.
- The sample website does not fall over.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed a34cb25 and pushed to 8.x. Thanks!

Committed as part of a merged commit for #2002650: [meta, no patch] improve maintainability by removing unused local variables

Automatically closed -- issue fixed for 2 weeks with no activity.