Remove unused local variables in the forum module

The patch attached is not for this issue, is the corresponding to #2080539
I send to re-test because it also can't be applied via git.

I attach the real one.

#1: drupal-core-remove-unused-local-variable-2080539.patch queued for re-testing.

The patch looks fine but I get 2 more unused variables in this file when running PHPMD:
core/modules/forum/lib/Drupal/forum/Tests/ForumTest.php:528 Avoid unused parameters such as '$node_user'.
core/modules/forum/lib/Drupal/forum/Tests/ForumTest.php:629 Avoid unused parameters such as '$forum'.
They are not such performance trouble but still should be included in this ticket.

Here is the new patch and interdiff.

The latest patch applies cleanly. Thanks.

+1 from me as well. This looks good... RTBC

Hm. That's quite a significant change. Sending to larowlan (Forum module maintainer) for review.

Let's also check the rest of the module for unused local variables.

Looks good!

6: drupal-core-remove-unused-local-variable-2080543-4.patch queued for re-testing.

The changes look fine to me to but @webchick has asked for @larowlan's input and the issue summary could do with an update.

Yes, that parameter is unused as well.

There are three unused use statements in forum.module - should they be removed here too?
these three:

use Drupal\Core\Language\Language;
use Drupal\taxonomy\Entity\Term;
use Drupal\node\NodeInterface;

As we're cleaning unused things - yep lets remove the unused use statements too :)

please don't credit me for this

Looking good!

Too late. :P

Committed and pushed to 8.x. Thanks!