Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Part of meta-issue #2002650: [meta, no patch] improve maintainability by removing unused local variables
File /core/modules/translation/lib/Drupal/translation/Tests/TranslationTest.php
Line 267: Unused local variable $translation_es
Comment | File | Size | Author |
---|---|---|---|
#21 | remove-unused-2080559-21.patch | 813 bytes | connorwk |
#19 | drupal-core-remove-unused-local-variables-from-translation-module-2080559-19.patch | 7.14 KB | eugenesia |
Comments
Comment #1
mrsinguyen CreditAttribution: mrsinguyen commentedComment #2
parthipanramesh CreditAttribution: parthipanramesh commentedpatch failed to apply..
Comment #3
xjmLet's also check for other unused local variables in the translation module.
Comment #4
xjmComment #5
Rajesh Ashok CreditAttribution: Rajesh Ashok commentedComment #6
Rajesh Ashok CreditAttribution: Rajesh Ashok commentedRemoved unused local variables in the content_translation module.
Comment #7
Rajesh Ashok CreditAttribution: Rajesh Ashok commentedComment #8
izus CreditAttribution: izus commentedthere are some unused
use
statements.will upload a patch within minutes
Comment #9
izus CreditAttribution: izus commenteddeleted some use statements that seems to be unused.
hopefully this goes green !
Comment #10
izus CreditAttribution: izus commentedThis one wasn't realy meant, i'll fix it back
Comment #11
izus CreditAttribution: izus commentedComment #12
izus CreditAttribution: izus commentedhere it is again
Comment #13
id.medionThe patch cannot be applied.
Comment #14
InternetDevels CreditAttribution: InternetDevels commentedReroll attached.
Comment #15
InternetDevels CreditAttribution: InternetDevels commentedRemoved tag "Needs Reroll"
Comment #16
eugenesia CreditAttribution: eugenesia commented14: drupal-core-remove-unused-local-variables-from-translation-module-2080559-14.patch queued for re-testing.
Comment #18
eugenesia CreditAttribution: eugenesia commentedPatch in #14 couldn't be applied as content_translation_menu() was removed in the latest dev version of the module.
Comment #19
eugenesia CreditAttribution: eugenesia commentedRerolled patch #14. Also verified with PhpStorm that the content_translation module doesn't have any unused variables or imported namespaces.
Comment #20
connorwk CreditAttribution: connorwk commentedHere at the Austin sprint.
Going to re-roll and review this.
Comment #21
connorwk CreditAttribution: connorwk commentedOk so I made a new patch because I realized in the current patch that I was working on re-rolling there are a lot of
use
statements removed that are not used. This is good work but is out of the scope of this issue and should have a new issue made for it or be put in one already existing for it.There was only one unused local variable in the content_translation module reported by phpStorm so I made a patch for that.
Should just need review and this issue should hopefully be RTBC.
Comment #22
sunAgreed that the use statements are out of scope.
Comment #24
alexpottCommitted aedaf11 and pushed to 8.x. Thanks!