Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Part of meta-issue #2002650: [meta, no patch] improve maintainability by removing unused local variables
File /core/modules/picture/lib/Drupal/picture/Tests/PictureAdminUITest.php
Line 56: Unused local variable $breakpoints
Comment | File | Size | Author |
---|---|---|---|
#1 | drupal-core-remove-unused-local-variable-2080589.patch | 604 bytes | mrsinguyen |
Comments
Comment #1
mrsinguyen CreditAttribution: mrsinguyen commentedComment #2
YesCT CreditAttribution: YesCT commented@mrsinguyen I added hints to the meta for reviewers. Would you like to review a few?
Comment #3
lokapujyaApplies, and is correct.
Comment #4
YesCT CreditAttribution: YesCT commented@lokapujya
how did you check? Did you apply it, and then use an IDE and ask it to find unused vars in the file?
Comment #5
lokapujyaGood question. I observed that breakpoints is an unused locally declared array and also ran an inspector in my IDE.
Comment #6
catchCommitted/pushed to 8.x, thanks!