Part of meta-issue #2002650: [meta, no patch] improve maintainability by removing unused local variables

File /core/includes/pager.inc

Line 163: Unused local variable $tags

CommentFileSizeAuthor
#3 3-2081135-remove-unused-local-variable-tags-pager-inc.patch470 bytesjan.stoeckler
#1 #1-2081135-remove-unused-local-variable-tags-pager-inc.patch470 bytesjan.stoeckler
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jan.stoeckler’s picture

jan.stoeckler
he/his
Primary language German
CreditAttribution: jan.stoeckler commented
Status: Active » Needs review
FileSize
#1-2081135-remove-unused-local-variable-tags-pager-inc.patch470 bytes

Removed the unused variable as per issue summary. Let's hope it works.

Status: Needs review » Needs work

The last submitted patch, #1-2081135-remove-unused-local-variable-tags-pager-inc.patch, failed testing.

jan.stoeckler’s picture

jan.stoeckler
he/his
Primary language German
CreditAttribution: jan.stoeckler commented
Status: Needs work » Needs review
FileSize
3-2081135-remove-unused-local-variable-tags-pager-inc.patch470 bytes

Another try, without the pound sign in the filename.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented
Status: Needs review » Reviewed & tested by the community

Thanks, looks good.

This line can in fact be removed, there's a 

  $tags = &$variables['tags'];

a couple lines down...

David Hernández’s picture

David Hernández CreditAttribution: David Hernández commented

Just a follow up on this issue. The patch still applies and it's RTBC.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed a34cb25 and pushed to 8.x. Thanks!

Committed as part of a merged commit for #2002650: [meta, no patch] improve maintainability by removing unused local variables

Automatically closed -- issue fixed for 2 weeks with no activity.