Part of meta-issue #2002650: [meta, no patch] improve maintainability by removing unused local variables

File /core/modules/php/lib/Drupal/php/Plugin/views/argument_validator/Php.php

Line 55: Unused local variable $view
Line 56: Unused local variable $handler

CommentFileSizeAuthor
#1 drupal-core-remove-unused-local-variable-2081159-1.patch670 bytessmira
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

smira’s picture

smira CreditAttribution: smira commented
Status: Active » Needs review
FileSize
drupal-core-remove-unused-local-variable-2081159-1.patch670 bytes
lorique’s picture

lorique CreditAttribution: lorique commented
Status: Needs review » Reviewed & tested by the community

Both variables safely removed from the method Drupal\php\Plugin\views\argument_validator\Php->validateArgument()

Changing status. Thank you for your patch @smiro

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

Patch no longer applies.

mrsinguyen’s picture

mrsinguyen CreditAttribution: mrsinguyen commented
Status: Needs work » Closed (won't fix)

PHP module removed from core #1203886: Remove the PHP module from Drupal core Assigned to: Dries

mrsinguyen’s picture

mrsinguyen CreditAttribution: mrsinguyen commented
Issue tags: -Novice, -Needs reroll