Quote selected (highlighted) text [#2081491]

This patch adds a functionality (which can be disabled) that will make the quote link add the highlighted text to the comment and have it quoted.

Comment	File	Size	Author
#3	quote-highlighted-text-2.patch	7.77 KB	attila.fekete
#3
#2	quote-highlighted-text-1.patch	6.59 KB	attila.fekete
#2
	quote-highlighted-text-0.patch	6.34 KB	attila.fekete

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

kalman.hosszu CreditAttribution: kalman.hosszu commented 4 September 2013 at 13:08

Status:

Needs review

» Needs work

+++ b/quote.admin.inc
@@ -55,6 +55,13 @@ function quote_settings_form() {
+  $form['quote']['highlighted_text'] = array(

You should delete the created variable during the uninstall process.

+++ b/quote.js
@@ -18,4 +18,74 @@ Drupal.behaviors.quote = {
+Drupal.behaviors.highlighted = {

Please use quoteHiglighted or something similar instead of "higlighted"

+++ b/quote.js
@@ -18,4 +18,74 @@ Drupal.behaviors.quote = {
+  attach: function(context) {

The attach function gets the settings variable too.

```
+++ b/quote.js
@@ -18,4 +18,74 @@ Drupal.behaviors.quote = {
+      var settings = Drupal.settings.quote[this.id];
```
You should use the settings param instead of Drupal.settings. In this case you have to modify the current settings variable's name.

+++ b/quote.js
@@ -18,4 +18,74 @@ Drupal.behaviors.quote = {
+      var textarea = settings.textarea;

Please use the new settings variable.

+++ b/quote.js
@@ -18,4 +18,74 @@ Drupal.behaviors.quote = {
+function insertAtCursor(object, text) {

I think this function should inside the behavior's class.

+++ b/quote.js
@@ -18,4 +18,74 @@ Drupal.behaviors.quote = {
+// Get user selection text on page

Please correct the function comment sesction.

+++ b/quote.js
@@ -18,4 +18,74 @@ Drupal.behaviors.quote = {
+function getSelectedText() {

This function should inside the behavior too.

After these modifications I will test the functionality. Thanks for the work @attila.fekete!

Comment #2

attila.fekete CreditAttribution: attila.fekete commented 5 September 2013 at 09:37

Status:

Needs work

» Needs review

File	Size
quote-highlighted-text-1.patch	6.59 KB

Hi Kalman, I fixed the issues you mentioned above, thanks for the review!

(Notice for the first one: it seems to me that we don't have to delete the variable, since all variables used in this module are merged into one variable ('quote') within the _quote_variable_get() function).

Comment #3

attila.fekete CreditAttribution: attila.fekete commented 30 September 2013 at 11:00

File	Size
quote-highlighted-text-2.patch	7.77 KB

Updated patch: highlighting feature now works with the 'Quote link' views field as well.

Comment #4

c470ip CreditAttribution: c470ip commented 4 November 2016 at 16:07

Issue summary:

View changes

Tried patch-0 and patch-2, none of them worked. The comments always get quoted completely, while nodes do not get quoted at all. Only [quote=*author*][/quote] tags are inserted and the following error occurs:

Notice: Undefined index: ru in the function _quote_get_quoted_data() (line 356 of file /home/***/www/sites/all/modules/quote/quote.module).