I made a view with:

- a page display, which is using the masonry style
- an attachment display, which is attached to the page, and which just shows a plain HTML list

The output looks totally broken, because the masonry JS is trying to affect the items in the attachment display too.

This is because the container selector that is passed to masonry is too general: we an HTML structure of DIVs with these classes :

- viewclass display class
-- attachment
--- viewclass display class
---- view_content
-- view_content

So the selector ".VIEWCLASS.DISPLAYCLASS .view_content" will hit both DIVs with the view_content class.

Patch coming.

CommentFileSizeAuthor
#1 2081731.masonry_views.views-attachments-targetted-by-masonry-selector.patch951 bytesjoachim
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joachim’s picture

joachim CreditAttribution: joachim commented
Status: Active » Needs review
FileSize
2081731.masonry_views.views-attachments-targetted-by-masonry-selector.patch951 bytes

Here's a patch.
I've split up the creation of the selector across several lines to make it clearer to follow.

Dom.’s picture

Dom. CreditAttribution: Dom. commented
Issue summary: View changes
Status: Needs review » Closed (fixed)

This was fixed meanwhile on the way to v3.