Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Details: see #1991684: Node history markers (comment & node "new" indicator, "x new comments" links) forces render caching to be per user, particularly the issue summary and comment 40.
This issue was split off from that issue because the render cache breakage of the Forum module does not break entity render caching, which is what we were trying to unblock there.
Comment | File | Size | Author |
---|---|---|---|
#9 | forum-history-markers-2082317-9-do-not-test.patch | 2.82 KB | colinafoley |
Comments
Comment #1
Wim LeersBetter title.
Blocked on #1991684: Node history markers (comment & node "new" indicator, "x new comments" links) forces render caching to be per user landing first.
Comment #2
Wim Leers#1991684: Node history markers (comment & node "new" indicator, "x new comments" links) forces render caching to be per user was committed.
Comment #3
Wim LeersWe need to get this going again
.
Comment #4
colinafoley CreditAttribution: colinafoley commentedComment #5
colinafoley CreditAttribution: colinafoley commentedComment #6
colinafoley CreditAttribution: colinafoley commentedI did some initial work on this and felt it was appropriate to add it as a patch. You can use it as a starting direction or leave it.
While investigating this issue I opened two other bug reports:
#2488886: Forum - "new replies" message is escaped
#2489374: Forum - status indicator does not respect forum status
I think more work needs to be done on Forum's rendering before proceeding with this issue.
Comment #7
Fabianx CreditAttribution: Fabianx for Acquia commentedThere is no patch, however ...
Comment #8
Wim Leers@colinafoley Any chance you could post the patch you had? :)
Comment #9
colinafoley CreditAttribution: colinafoley at Lehigh University commentedSorry everyone! Here's the WIP patch. Most of this is based off of how Comment handles history markers.
Comment #10
Wim Leers#2082315: Tracker history markers ("new" and "updated" markers, "x new replies" links) forces render caching to be per user now has landed as well. Which means this is the last "history breaks cacheability" issue.
Comment #11
larowlanComment #12
lauriiiI'm working on this
Comment #13
lauriiiNot working on this right now. Maybe later
Comment #14
larowlanMore accurate status
Comment #27
quietone CreditAttribution: quietone at PreviousNext commentedForum is approved for removal. See #1898812: [policy] Deprecate forum module for removal in Drupal 11
This is now Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.
It will be moved to the contributed extension once the Drupal 11 branch is open.