This module integrates with the Media module. It allows editors to retrieve ARTstor Shared Shelf images. Images are managed in Shared Shelf and users create pointers to them in Drupal. Editors can add images using the Shared Shelf image ID. Or an editor may prefer to select a project (and/or sets within it), as well as search project image metadata to choose images to add as media items. Editors choose their Shared Shelf images within the Media browser, both for fields and within WYSIWYG. The module is only useful to ARTstor Shared Shelf users since you need to have an active account. The module is similar to the Flickr module, but it differs in that it must use the Shared Shelf API to authenticate and retrieve content. The API requires a cookie sent at authentication time is included in each request header sent to the Shared Shelf server.
git clone --branch 7.x-2.x http://git.drupal.org/sandbox/jlk4p/1808830.git media_sharedshelf
Comments
Comment #1
PA robot CreditAttribution: PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxjlk4p1808830git
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #2
jlk4p CreditAttribution: jlk4p commentedCleaned up issues identified by the PA robot. Left three item in media_sharedshelf.admin.inc:
Line 613: need to use $form_state['input'] because of AJAX process going on and checkbox states being examined.
Line 763 and 790: the global variable $_media_sharedshelf_cookies is being used when assigned a value returned by another function call if necessary.
Comment #3
alexmoreno CreditAttribution: alexmoreno commentedHi jlk4p,
the git clone link is wrong, it is pointing to your personal repository and it should point to the public one:
git clone --branch 7.x-2.x http://git.drupal.org/sandbox/jlk4p/1808830.git media_sharedshelf
(note the folder at the end).
The code looks clean and well documented. As I was also suggested (https://drupal.org/node/2083831#comment-7844441), I would move the non-hook functions to and inc file.
Also, instead of using include_once I would use module_load_include, and I'd call it not in the beginning of the file but extrictly when you are going to need this library/functions.
You still have issues with your coding standars, but it seems that, as you suggested, they are false possitive.
FILE: ...ww/drupal-7-pareview/pareview_temp/includes/media_sharedshelf.admin.inc
--------------------------------------------------------------------------------
FOUND 0 ERROR(S) AND 3 WARNING(S) AFFECTING 3 LINE(S)
--------------------------------------------------------------------------------
613 | WARNING | Do not use the raw $form_state['input'], use
| | $form_state['values'] instead where possible
763 | WARNING | Unused global variable $_media_sharedshelf_cookies.
790 | WARNING | Unused global variable $_media_sharedshelf_cookies.
--------------------------------------------------------------------------------
I would highly recommend you to help with other reviews to accelerate yourself. I am waiting for reviews so ;-): https://drupal.org/node/2083831
Comment #4
alexmoreno CreditAttribution: alexmoreno commentedneeds work and some third reviews.
Comment #4.0
alexmoreno CreditAttribution: alexmoreno commentedChange direct link to git repository to reference 7.x-2.x branch instead of master.
Comment #4.1
jlk4p CreditAttribution: jlk4p commentedFixed the git clone link reference based on feedback from urwen.
Comment #4.2
jlk4p CreditAttribution: jlk4p commentedForgot to add module reference to git clone statement
Comment #5
PA robot CreditAttribution: PA robot commentedClosing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).
I'm a robot and this is an automated message from Project Applications Scraper.