Hi all, this module is great! Big up to the author!

I believe this is related to this issue? https://drupal.org/node/987624

I have a relation type with a field attached (boolean true/false checkbox). On the endpoint entity's edit form, the Relation Add widget shows the field with the checkable box, and the edit form appears to successfully pass the value of the field to the relation entity, but I get the following error on save:

Strict warning: Only variables should be passed by reference in relation_add_field_update() (line 914 of /sites/all/modules/relation_add/relation_add.module).

CommentFileSizeAuthor
#2 relation_add-fix_reference_error-2083101-2.patch780 bytesridgek
#1 relation_add-fix_reference_error-2083101-1.patch781 bytesridgek
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ridgek’s picture

ridgek CreditAttribution: ridgek commented
FileSize
relation_add-fix_reference_error-2083101-1.patch781 bytes

Made a patch. I think this works?

PS, this is my first Drupal patch ever!!!!! \(^_^)/

ridgek’s picture

ridgek CreditAttribution: ridgek commented
FileSize
relation_add-fix_reference_error-2083101-2.patch780 bytes

Oops, sorry. Use this one. *facepalm*

Paul B’s picture

Paul B CreditAttribution: Paul B commented
Status: Active » Needs review
Paul B’s picture

Paul B CreditAttribution: Paul B commented
Category: task » bug
bmango’s picture

bmango CreditAttribution: bmango commented

I was having the same problem and the patch in #2 worked perfectly for me.

Many thanks.

Paul B’s picture

Paul B CreditAttribution: Paul B commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
mr.york’s picture

mr.york CreditAttribution: mr.york commented
Status: Reviewed & tested by the community » Fixed

Thank you patch!
I'v commited.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.