Unit test for the Drupal\serialization\Normalizer\ListNormalizer class.

Related to #2082735: Unit test Drupal\serialization\Normalizer\TypedDataNormalizer class

Files: 
CommentFileSizeAuthor
#11 2083175-11.patch1.88 KBdamiankloip
PASSED: [[SimpleTest]]: [MySQL] 58,882 pass(es).
[ View ]
#11 interdiff-2083175-11.txt982 bytesdamiankloip
#6 2083175-6.patch1.46 KBdamiankloip
PASSED: [[SimpleTest]]: [MySQL] 59,325 pass(es).
[ View ]
d8.ListNormalizerTest.patch3.27 KBdamiankloip
PASSED: [[SimpleTest]]: [MySQL] 58,858 pass(es).
[ View ]

Comments

Status:Needs review» Reviewed & tested by the community

Perfect

Status:Reviewed & tested by the community» Fixed

Committed and pushed to 8.x. Thanks!

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Status:Closed (fixed)» Needs work

+++ b/core/modules/serialization/tests/Drupal/serialization/Tests/Normalizer/ListNormalizerTest.phpundefined
@@ -0,0 +1,105 @@
+
+  /**
+   * The TypedDataNormalizer instance.
+   *
+   * @var \Drupal\serialization\Normalizer\TypedDataNormalizer
+   */
+  protected $normalizer;

It looks like there are some copy/paste issues with this test.

Also, it would be nice to have some comments in the setUp().

Status:Needs work» Needs review
StatusFileSize
new1.46 KB
PASSED: [[SimpleTest]]: [MySQL] 59,325 pass(es).
[ View ]

Should the @group be Drupal? It looked like it was specific to the package in other tests.

Also, the getInfo method needs to be switched from TypedData to List.

Should the @group be Drupal? It looked like it was specific to the package in other tests.

Yeah this would be great to add.

Status:Needs review» Needs work

Status:Needs work» Needs review
StatusFileSize
new982 bytes
new1.88 KB
PASSED: [[SimpleTest]]: [MySQL] 58,882 pass(es).
[ View ]

Fair, how about...

Status:Needs review» Reviewed & tested by the community

I should have reviewed it with more clarity.

Status:Reviewed & tested by the community» Fixed

Committed/pushed to 8.x, thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue summary:View changes

Updated issue summary.