In #2075949: Add Libricons to messages, we came to the conclusion that the dblog module should update icon usage to SVG, following the new practices for implementation (see #2032773: Use Libricons (icon font) in Seven, consider using it more broadly in core).

This module uses the file "message-16-warning.png" at line 43 in dblog.module.css and "message-16-error.png" at line 49 in dblog.module.css

Files: 
CommentFileSizeAuthor
#6 dblog-svg-icons.png178.61 KBrteijeiro
#4 dblog_libricons_2083945_4.patch1.03 KBOuti
PASSED: [[SimpleTest]]: [MySQL] 58,358 pass(es).
[ View ]

Comments

Title:Update use of icons to new standardsdblog.module: Update use of icons to new standards

...less vague title (there are at least 3 issues with the same name: #2075949-10: Add Libricons to messages).

taggin

Title:dblog.module: Update use of icons to new standardsdblog.module: Update use of icons and colors to new standards

Worth having a quick look over the colours used, to see if we can align them with messages

StatusFileSize
new1.03 KB
PASSED: [[SimpleTest]]: [MySQL] 58,358 pass(es).
[ View ]

I made a patch with the svg icons we actually have.

By taking a look over the colors, do you mean the icon colors should be changed to match the message colors or the opposite? Anyway, the error icon color is now #ea2800 and the error message (border) color is #e62600. The warning icon color is #e29700 and the warning message (border) color is #e09600.

Status:Active» Needs review

Status:Needs review» Reviewed & tested by the community
StatusFileSize
new178.61 KB

Tested the patch and seems good for me. (See screenshot)

dblog-svg-icons.png

SVG icons are loaded and also tried the no-svg fallback in IE8 and works well.

It's a RTBC for me.

Title:dblog.module: Update use of icons and colors to new standardsdblog.module: Update use of icons

It was a bad idea to add colours to this issue, it's covered in #2070323: Apply seven style guide to dblog. The icons patch is RTBC.

Status:Reviewed & tested by the community» Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue summary:View changes

added more info