Line 61 of includes/commerce_registration.forms and line 172 of commerce_registration.module use an "isset" statement and should be using a !empty instead to make sure the array isn't empty. Otherwise the loop that follows tries to iterate over empty array contents and throws a PHP notice.

CommentFileSizeAuthor
#1 changetonotempty-2084973-1.patch1.33 KBdeggertsen
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

deggertsen’s picture

Status: Active » Needs review
FileSize
1.33 KB

Here's a patch applied against dev. I agree with the logic above.

  • Commit 6a23ee5 on 7.x-2.x by blacklabel_tom:
    Issue #2084973 by john.oltman,deggertsen: Fixed an instance where empty...
blacklabel_tom’s picture

Version: 7.x-2.0-beta5 » 7.x-2.x-dev
Issue summary: View changes
Status: Needs review » Fixed

This has been merged into 7.x-2.x-dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.