In PHP 5.5, the PREG_REPLACE function's /e switch is deprecated. Replace its use in the Oracle Driver with PREG_REPLACE_CALLBACK.

Following functions are affected:
escapeReserved
escapeAnsi

Fixing escapeAnsi is pretty easy, escapeReserved is a bit more difficult since my limited regex knowledge keeps me from fully understanding the output of the replace regexes.

[Edit - code removed because its wrong]

CommentFileSizeAuthor
#2 Replace preg_replace-e with preg_replace_callback-2085013-2.patch4.39 KBsiromega
#1 Replace preg_replace-e with preg_replace_callback-2085013-1.patch4.34 KBsiromega
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

siromega’s picture

siromega CreditAttribution: siromega commented
Assigned: Unassigned » siromega
Status: Active » Needs work
Issue tags: +preg_replace(), +preg_replace_callback()
FileSize
Replace preg_replace-e with preg_replace_callback-2085013-1.patch4.34 KB

Here is my patch. Was a quick port, it still needs testing (I haven't been able to get my environment correct for Drupal on PHP 5.5 on linux yet, so I cant test it).

It only works in PHP 5.3.x and above - because it uses anonymous functions it doesn't work on PHP 5.2.x. PHP 7.x supports 5.2.5+ so is this something we want to break?

siromega’s picture

siromega CreditAttribution: siromega commented
FileSize
Replace preg_replace-e with preg_replace_callback-2085013-2.patch4.39 KB

Minor fix for one of the regexes (finally got my instance up and running).

siromega’s picture

siromega CreditAttribution: siromega commented
Issue summary: View changes

Removed incorrect code