Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Encryption method plugins have an option for additional settings, similar to the settings for key providers. If a settings form is defined, however, it is not displayed on the Encrypt configuration page.
Comment | File | Size | Author |
---|---|---|---|
#3 | encrypt-method-settings-rot13-2085097-1.txt | 1.33 KB | rlhawk |
#2 | encrypt-method-settings-2085097-1.patch | 4.23 KB | rlhawk |
#1 | settings-encryption-methods-2085097-0.patch | 2.82 KB | rlhawk |
Comments
Comment #1
rlhawkHere is a patch that adds what is needed to display the additional settings form for an encryption method and save the settings.
Comment #2
rlhawkThis patch needed to be re-rolled, due to the introduction of configurations, so here's the new file.
I should note that it's not possible to test this functionality with the standard encryption method plugins, since none uses additional method settings. I created a new method for testing, which I will attempt to attach to a subsequent comment.
Comment #3
rlhawkHere's a new encryption method plugin that can be used for testing. It adds a settings form with one useless field, but it's good for confirming that the settings are displayed and saved. Change the filename to "rot13.inc" and place it in encrypt/plugins/encryption_methods.
Comment #4
crashtest_ CreditAttribution: crashtest_ commentedLooks good, if($method) should be caught in a further code cleanup with the if($method) in key providers, as well as any other code cleanup issues we can find, but I like this patch as it sits.
Comment #6
rlhawkDuly noted. I've committed the patch.