Encryption method plugins have an option for additional settings, similar to the settings for key providers. If a settings form is defined, however, it is not displayed on the Encrypt configuration page.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rlhawk’s picture

Status: Active » Needs review
FileSize
2.82 KB

Here is a patch that adds what is needed to display the additional settings form for an encryption method and save the settings.

rlhawk’s picture

Issue summary: View changes
FileSize
4.23 KB

This patch needed to be re-rolled, due to the introduction of configurations, so here's the new file.

I should note that it's not possible to test this functionality with the standard encryption method plugins, since none uses additional method settings. I created a new method for testing, which I will attempt to attach to a subsequent comment.

rlhawk’s picture

Here's a new encryption method plugin that can be used for testing. It adds a settings form with one useless field, but it's good for confirming that the settings are displayed and saved. Change the filename to "rot13.inc" and place it in encrypt/plugins/encryption_methods.

crashtest_’s picture

Status: Needs review » Reviewed & tested by the community

Looks good, if($method) should be caught in a further code cleanup with the if($method) in key providers, as well as any other code cleanup issues we can find, but I like this patch as it sits.

  • rlhawk committed 14893e5 on 7.x-2.x
    Issue #2085097 by rlhawk: Actually use settings for encryption methods.
    
rlhawk’s picture

Status: Reviewed & tested by the community » Fixed

Duly noted. I've committed the patch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.