Most payment statuses require static metadata and will extend the default base class. Instead of using annotated plugins, we should use YAML files for status declarations and use derivatives for more complex solutions.

CommentFileSizeAuthor
#12 payment_2085203_12.patch19.1 KBXano
#12 interdiff.txt608 bytesXano
#8 payment_2085203_8.patch19.07 KBXano
#8 interdiff.txt6.32 KBXano
#7 payment_2085203_7.patch16.35 KBXano
#7 interdiff.txt915 bytesXano
#5 payment_2085203_5.patch16.36 KBXano
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented

This can't be done, until core can extract translatable strings from contrib modules' yml files.

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented
Issue summary: View changes
Status: Active » Closed (won't fix)
Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented
Status: Closed (won't fix) » Postponed
Related issues: +#2088371: YAML discovery incompatible with translations, +#2322839: Unify YAML translation extraction, and allow extension by contrib.
Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented
Status: Postponed » Active

#2322839: Unify YAML translation extraction, and allow extension by contrib. has now been fixed.

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented
Status: Active » Needs review
FileSize
payment_2085203_5.patch16.36 KB

Needs a manual test to check if POTX can extract the strings.

Status: Needs review » Needs work

The last submitted patch, 5: payment_2085203_5.patch, failed testing.

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented
Status: Needs work » Needs review
FileSize
interdiff.txt915 bytes
payment_2085203_7.patch16.35 KB

Still needs manual testing. Apparently potx-cli.php was removed from POTX.

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented
FileSize
interdiff.txt6.32 KB
payment_2085203_8.patch19.07 KB

I manually confirmed that POTX can extract the strings. This patch makes sure the translatables in the plugin definition are wrapped in TranslationWrapper objects so they are portable across languages.

Status: Needs review » Needs work

The last submitted patch, 8: payment_2085203_8.patch, failed testing.

Status: Needs work » Needs review

Xano queued 8: payment_2085203_8.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 8: payment_2085203_8.patch, failed testing.

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented
Status: Needs work » Needs review
FileSize
interdiff.txt608 bytes
payment_2085203_12.patch19.1 KB
Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented
Status: Needs review » Fixed

  • Xano committed 24dcefe on 8.x-2.x 
    Issue #2085203 by Xano: Added Use YAML discovery for payment statuses.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.