#2015789: Remove language_css_alter() (RTL stylesheets) in favor of HTML 'dir' attribute moved Drupal to a more modern way of handling RTL CSS.

However, not all "-rtl.css" references were removed.

This patch addresses the remainder.

Files: 
CommentFileSizeAuthor
remove_remaining_rtl_css_references.patch3.88 KBWim Leers
PASSED: [[SimpleTest]]: [MySQL] 58,690 pass(es).
[ View ]

Comments

Status:Needs review» Reviewed & tested by the community

Did you grep for any other leftover -rtl occurrences? If so, then I guess we can RTBC this already.

Issue tags:+sprint, +language-base

Agreed, looks good.

#1: I did.

Status:Reviewed & tested by the community» Needs work

Do any of these need to be incorporated in the patch?

Searching 5583 files for "-rtl"

core/modules/color/css/color.admin.css:
   75:   background: url(images/hook-rtl.png) no-repeat 0 0;
core/modules/system/css/system.theme.css:
  387:   list-style-image: url(../../misc/menu-collapsed-rtl.png);
core/themes/bartik/css/style.css:
  820:   background-image: url(../images/comment-arrow-rtl.gif);
core/themes/seven/style.css:
  464:   background: url(images/list-item-rtl.png) no-repeat right 11px;
1086:   background: transparent url(images/task-item-rtl.png) no-repeat right 50%;
5 matches across 4 files

Searched for -rtl excluding vendor/* after applying the patch from the issue summary.

Status:Needs work» Reviewed & tested by the community

No this issue is about removing references / uses of the old -rtl.css autodiscovery feature. Image replacements for RTL still apply.

Indeed — but thanks for the double-checking! :)

Ok cool, RTBC +1:)

Status:Reviewed & tested by the community» Fixed

Committed and pushed to 8.x. Thanks!

Issue tags:-sprint

Yay, thanks all!

Status:Fixed» Closed (fixed)
Issue tags:+sprint

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags:-sprint

Superb, thanks!