Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Add support for touch icons:
- https://developer.apple.com/library/ios/documentation/AppleApplications/...
- https://mathiasbynens.be/notes/touch-icons
Original request:
See https://developer.apple.com/library/ios/documentation/AppleApplications/... for documentation.
The tag value contains three comma-separated parameters; I'm not completely familiar with the Meta Tag API yet, but I think it would be ideal if these were implemented as separate fields and then combined automatically.
Comment | File | Size | Author |
---|---|---|---|
#16 | metatag-n2085747-16.patch | 8.21 KB | DamienMcKenna |
Comments
Comment #1
jazzslider CreditAttribution: jazzslider commentedThe attached patch implements a very basic version of this. I did not, unfortunately, see a way to implement the three named parameters as separate fields, so those using this tag will have to enter the entire string as defined in the docs. That's probably acceptable to most people who would use this.
Comment #2
jbrown CreditAttribution: jbrown commentedShouldn't it be
<meta name="apple-itunes-app" content="app-id=#" />
instead of
<meta property="apple-itunes-app" content="app-id=#" />
Comment #3
jazzslider CreditAttribution: jazzslider commentedIndeed it should —thanks for the catch, I've updated the patch accordingly.
Comment #4
DamienMcKennaI think this needs some a little further work:
Comment #5
jazzslider CreditAttribution: jazzslider commentedPlease see my latest patch, which implements your recommendations.
Thanks!
Adam
Comment #6
DamienMcKennaLets expand this to cover Apple's other meta tags too.
Comment #7
DamienMcKennaClosed a duplicate: #2382749: Add support for apple-touch-icon link meta tags
Comment #8
Dave ReidNote that 'apple-touch-icon' is used by a lot more than just Apple devices, so caution in how it's labeled otherwise it might be easily ignored.
Comment #9
Dave ReidFor reference: https://mathiasbynens.be/notes/touch-icons
Comment #10
DamienMcKennaLets refocus the request.
Comment #11
DamienMcKennaComment #12
Dave ReidRelated project: https://www.drupal.org/project/responsive_favicons
Comment #13
DamienMcKenna+1 for the responsive_favicons module, it and the service it uses (http://realfavicongenerator.net/) work really well.
Comment #14
DamienMcKennaThis adds a bunch of favicon formats, but needs some further work; uploading it here so I don't accidentally loose what I'm working on.
FYI I figure that this could focus on adding favicons and favicon-type meta tags.
Comment #15
DamienMcKennaStandardized the issue title.
Comment #16
DamienMcKennaThis tidies up the code a bit, makes the meta tags only work globally, and the output works now.
Comment #18
DamienMcKennaCommitted. Woot!
Please open new issues for any other favicons that could be added.