Core still has a couple surprising references to field_sql_storage:
- Some tests try to enable it - you'd expect this would break, but it seems to pass
- DatabaseSotrageController::onBundleRename() checks $field['storage']['type'], which doesn't exist anymore. Shows we lack some tests here.

Files: 
CommentFileSizeAuthor
#11 interdiff.txt1.25 KBHydra
#11 field_sql_storage-2086095-11.patch12.99 KBHydra
PASSED: [[SimpleTest]]: [MySQL] 59,203 pass(es).
[ View ]
#10 field_sql_storage-2086095-10.patch14.36 KBswentel
PASSED: [[SimpleTest]]: [MySQL] 58,635 pass(es).
[ View ]
#8 field_sql_storage-2086095-8.patch14.29 KByched
PASSED: [[SimpleTest]]: [MySQL] 59,175 pass(es).
[ View ]
#2 field_sql_storage-2086095-2.patch14.33 KByched
PASSED: [[SimpleTest]]: [MySQL] 58,727 pass(es).
[ View ]
#1 field_sql_storage-2086095-1.patch16.68 KByched
PASSED: [[SimpleTest]]: [MySQL] 58,555 pass(es).
[ View ]

Comments

Status:Active» Needs review
StatusFileSize
new16.68 KB
PASSED: [[SimpleTest]]: [MySQL] 58,555 pass(es).
[ View ]

Patch.

- There was another problem in DatabaseStorageController::onBundleRename() - the method now runs before instances are updated, so we need to get instances associated to the old bundle name.
- The test needed to fix inconsistencies in entity_test_[create|rename|delete]_bundle() as compared to entity_test_entity_bundle_info(). Hope this won't break other things :-/

StatusFileSize
new14.33 KB
PASSED: [[SimpleTest]]: [MySQL] 58,727 pass(es).
[ View ]

#1 had some tests commented out...

Status:Needs review» Needs work

The last submitted patch, field_sql_storage-2086095-2.patch, failed testing.

Status:Needs work» Needs review

#2: field_sql_storage-2086095-2.patch queued for re-testing.

Issue tags:+Field API, +Entity Field API

Tagging.

Status:Needs review» Reviewed & tested by the community

Awesome, @yched++!

+++ b/core/lib/Drupal/Core/Entity/DatabaseStorageController.php
@@ -867,22 +867,22 @@ public function onInstanceDelete(FieldInstanceInterface $instance) {
-    // We need to account for deleted or inactive fields and instances.
-    $instances = field_read_instances(array('entity_type' => $this->entityType, 'bundle' => $bundle_new), array('include_deleted' => TRUE, 'include_inactive' => TRUE));
+    // We need to account for deleted or inactive fields and instances. The
+    // method runs before the instance definitions are updated, so we need to
+    // fetch them using the old bundle name.
+    $instances = field_read_instances(array('entity_type' => $this->entityType, 'bundle' => $bundle), array('include_deleted' => TRUE, 'include_inactive' => TRUE));

Nice, that's why the call below doesn't fail ;)

No test-only patch, but I manually confirmed that the added tests fail without the fix. Changes look great, so I think this is ready to go.

Status:Reviewed & tested by the community» Needs work
Issue tags:+Needs reroll

Patch no longer applies.

Status:Needs work» Reviewed & tested by the community
StatusFileSize
new14.29 KB
PASSED: [[SimpleTest]]: [MySQL] 59,175 pass(es).
[ View ]

Reroll

Status:Reviewed & tested by the community» Needs work

Patch no longer applies.

Status:Needs work» Reviewed & tested by the community
Issue tags:-Needs reroll
StatusFileSize
new14.36 KB
PASSED: [[SimpleTest]]: [MySQL] 58,635 pass(es).
[ View ]

StatusFileSize
new12.99 KB
PASSED: [[SimpleTest]]: [MySQL] 59,203 pass(es).
[ View ]
new1.25 KB
  1. +++ b/core/modules/editor/lib/Drupal/editor/Tests/EditorFileUsageTest.php
    @@ -19,7 +19,7 @@ class EditorFileUsageTest extends DrupalUnitTestBase {
    +  public static $modules = array('system', 'editor', 'editor_test', 'filter', 'node', 'entity', 'field', 'text', 'file');

    The module list in EditorFileUsage test has been shortened in #1605290: Enable entity render caching with cache tag support, so I removed this one from the patch.

  2. +++ b/core/modules/node/lib/Drupal/node/Tests/NodeValidationTest.php
    @@ -19,7 +19,7 @@ class NodeValidationTest extends DrupalUnitTestBase {
    +  public static $modules = array('node', 'entity', 'field', 'text', 'filter');

    Same here

Rerolled the patch with the changes, so basically nothing changed and still RTBC.

Status:Reviewed & tested by the community» Needs work
Issue tags:-Field API, -Entity Field API

The last submitted patch, field_sql_storage-2086095-11.patch, failed testing.

Status:Needs work» Needs review
Issue tags:+Field API, +Entity Field API

#11: field_sql_storage-2086095-11.patch queued for re-testing.

Status:Needs review» Reviewed & tested by the community

Should be bot fluke

Status:Reviewed & tested by the community» Fixed

Committed e40eb19 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.