Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Updated: Comment #N
Problem/Motivation
Now that we have block categories on the block listing page it doesn't make sense to prefix views blocks with 'View:'
Proposed resolution
Remove this hardcoded prefix from the block admin_label created in the ViewsBlock derivative class.
Remaining tasks
Patch, review, etc...
User interface changes
'View:' prefix will disappear from views blocks in block UI listings
API changes
None
Related Issues
#2071019: Allow the block category for Views block displays to be edited
Comment | File | Size | Author |
---|---|---|---|
#4 | vdc-2086447-4.patch | 6.17 KB | tim.plunkett |
#4 | interdiff.txt | 5.13 KB | tim.plunkett |
db.viewsBlock-remove-prefix.patch | 1.04 KB | damiankloip | |
Comments
Comment #1
tim.plunkettIf this passes, we should add tests. Especially for that if/else for the display being appended.
Comment #2
damiankloip CreditAttribution: damiankloip commentedI'm pretty sure the title is not being tested currently. Not explicitly anyway.
Comment #4
tim.plunkettDrupal\block\Tests\Views\DisplayBlockTest failing is good enough for me (and that's not the only one)
Comment #5
jibranLet's remove t seems redundant anyways. :)
Comment #6
dawehnerDoes someone understand why/whether the label is escaped on $view->label() already?
Comment #7
damiankloip CreditAttribution: damiankloip commentedI guess it's totally not, just comes directly from the property.
Comment #8
dawehnerMaybe the description is escaped later?
Comment #9
damiankloip CreditAttribution: damiankloip commentedWell, I think the BlockListController will escape it before rendering. Is that what you mean?
Comment #10
tim.plunkettYes these are assumed to be unescaped by the block list (and elsewhere), we explicitly call check_plain in those places
Comment #11
damiankloip CreditAttribution: damiankloip commentedAgree that DisplayBlockTest covers this.
Comment #12
webchickAwesome. Thanks folks!
Committed and pushed to 8.x.