When using select or other for a custom og:type I get the following error every time I save a node.

Notice: Undefined index: #other_delimiter in select_or_other_element_process() (line 138 of /Users/marcus/hosts/drupal7/sites/all/modules/contrib/select_or_other/select_or_other.module).
Notice: Undefined index: #other_delimiter in select_or_other_element_process() (line 163 of /Users/marcus/hosts/drupal7/sites/all/modules/contrib/select_or_other/select_or_other.module).
Files: 
CommentFileSizeAuthor
#4 undefined-index-2086643-8585801.patch1.23 KBshahinam
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es).
[ View ]

Comments

Any ideas on this, would be nice to get rid of it.

I've not had a chance to test it yet, but I will soon.

Issue summary:View changes

In widget settings form the other_delimiter form element is commented.
The comment above it says:

There are design issues with saving multiple other values with some field widgets - this needs a rethink.

So it is obvious it will throw notice, where ever we try to fetch this array key.
Attached is a simple, patch to comment out those lines.

StatusFileSize
new1.23 KB
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es).
[ View ]

Status:Active» Needs review

Status:Needs review» Needs work

The last submitted patch, 4: undefined-index-2086643-8585801.patch, failed testing.

Project:Metatag» Select (or other)
Version:7.x-1.0-beta7» 7.x-3.x-dev
Component:User interface» CCK / Field API widget

Oops, this is not metatag module issue.
Instead select_or_other has this issue. Assigning to that project.

Status:Needs work» Needs review

Version:7.x-3.x-dev» 7.x-2.x-dev
Status:Needs review» Needs work

Commenting out the offending lines doesn't fix the problem, it only hides the symptoms.

Agreed!
As mentioned in comment, I did this because the form element is commented in select_or_other.field_widget.inc on line 285

  /*
  There are design issues with saving multiple other values with some field widgets - this needs a rethink.
  $form['other_delimiter'] = array(
    '#type' => 'textfield',
    '#title' => t('Other delimiter'),
    '#description' => t("Delimiter string to delimit multiple 'other' values into the <em>other</em> textfield.  If you enter <em>FALSE</em> only the last value will be used."),
    '#default_value' => isset($settings['other_delimiter']) ? $settings['other_delimiter'] : ', ',
    '#required' => TRUE,
    '#size' => 5,
  );
  */