Updated: Comment #0

Follow-up from #2078951: Highlight the row of block that was just placed

Problem/Motivation

Makes me want to keep clicking "Save blocks" over and over.

Steps to reproduce

  1. install d8
  2. go to Administration >> Structure >> Block Layout (admin/structure/block)
  3. place a block (for example place recent comments in the first sidebar)
  4. it gets a changed color and we end up at url admin/structure/block/list/bartik?block-placement=bartikrecentcomments
  5. scroll to bottom of page and save (Save blocks)
  6. page reloads and we are still at admin/structure/block/list/bartik?block-placement=bartikrecentcomments

Proposed resolution

Remove the query string from the url when the save button is submitted.

Remaining tasks

User interface changes

Before patch

Before save and after save:
placed-block.png

API changes

None.

CommentFileSizeAuthor
#3 block-2088027-3-PASS.patch1.91 KBtim.plunkett
#3 block-2088027-3-FAIL.patch1.28 KBtim.plunkett
#1 block-2088027-1.patch811 bytestim.plunkett
placed-block.png137.05 KBYesCT
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Active » Needs review
Issue tags: +Needs tests
FileSize
block-2088027-1.patch811 bytes

Should be easy enough to test.

This just removes the querystring after submit.

The last submitted patch, block-2088027-1.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Issue summary: View changes
Status: Needs work » Needs review
Issue tags: -Needs tests
FileSize
block-2088027-3-FAIL.patch1.28 KB
block-2088027-3-PASS.patch1.91 KB

The last submitted patch, 3: block-2088027-3-FAIL.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

Perfect!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

  • Commit f82579c on 8.x by webchick: 
    Issue #2088027 by tim.plunkett | YesCT: Just placed block keeps changed...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.