When I enable maestro module, I get white space (2 lines break) before < !DOCTYPE > tag. Why?
Screenshot available.

CommentFileSizeAuthor
#2 maestro-remove-closing-php-tag-2088259-1.patch244 bytespatrick_durold
After enable Maestro26.75 KBijortengab
Before enable Maestro28.04 KBijortengab
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rylowry@gmail.com’s picture

rylowry@gmail.com CreditAttribution: rylowry@gmail.com commented

I'm experiencing the same problem on version 7.x-1.4

patrick_durold’s picture

patrick_durold
Primary language German
CreditAttribution: patrick_durold commented
Version: 7.x-1.2 » 7.x-1.x-dev
Status: Active » Needs review
FileSize
maestro-remove-closing-php-tag-2088259-1.patch244 bytes

The problem is caused by a closing "?>" PHP tag and the following newlines at the end of lib/lib-og_common.php. When this file is included during the bootstrap, it will output these newlines and cause all sorts of problems (in my case, with XML output).

Attached patch will remove the closing tag and fix the issue.

larskleiner’s picture

larskleiner CreditAttribution: larskleiner commented

It would be great if we can get this patch commited to 1.x-dev as our drush make build script can't seem to apply the patch.

This works: patch -p1 < maestro-remove-closing-php-tag-2088259-1.patch

However this doesn't work (that's what drush make seems to be using): git apply maestro-remove-closing-php-tag-2088259-1.patch

blainelang’s picture

blainelang CreditAttribution: blainelang commented
Status: Needs review » Fixed

Thanks Patrick, the patch has been committed: http://drupalcode.org/project/maestro.git/commit/77bc863

blainelang’s picture

blainelang CreditAttribution: blainelang commented
Issue summary: View changes

edit text.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.