[D6] Interswitch Donate

Hi feyisaso, and thank you for your effort,

firstly, your git clone instructions are wrong, use the public ones please.

You have a lot of issues, mainly coding standards, please review them so it will be easier to read and review your code:
http://pareview.sh/pareview/httpgitdrupalorgsandboxfeyisayo2086825git

Your git main branch in the -dev one. Change it to use the 1.x instead.

Lastly, help with at least 3 reviews (more recommended):
https://drupal.org/node/1975228

once done, add yourself the bonus review tag and your module will be reviewed a lot quicker.

Thanks again.

some more advices regarding your code.

Your .module is quite big, and in the opposite the inc is very small. All your hook functions should be placed in the .inc.

On the other hand, to help the readibility, I'd place the .js in a /js folder, instead of using the includes.

In lines 824 for example, you have a lot of html mixed in the php code. You can use different techniques to move this html to an html template (mixing html and php is ugly, and should be carefully used).

In line 736 you have some potential injection security holes. Add this variables in the db_query function and change:

WHERE user_id = '{$user->uid}'";

with something like:

WHERE user_id = '%s'";

In line 692 you use a default timezone. Is there any way to change this in the module if I am, for example, in London?

Thanks a lot for your work, do not forget about contributing with some third module reviews :-).

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Please find below some of my initial reiew comments:

1. Add function level comments to _requery_isw
2. Callback 'admin/interswitch-donate/ajax/requery' should have one more parameter. This woul avoid need to check for arg(4) at callback function level.
3. function _goto_interswitch: Try to move HTMl into a separate template file
4. It is always good practice to start function names with module name in order to avoid clash with other modules.

Changing status to needs work.

Hi,

It is exactly why it is your first modulethe reason why it is important to do some recurved, learn the process Ab learn about coding in drupal :-)

Removing review bonus tag, you have not done all manual review, you just posted the output of an automated review tool. Make sure to read through the source code of the other projects, as requested on the review bonus page.

I get some errors, see: http://pareview.sh/pareview/httpgitdrupalorgsandboxfeyisayo2086825git

Hello,

I did a quick run through. Hopefully at least one of the comments below is helpful.

• In your CSS file, do not attach units to zero-values. 0px should be 0. Alphabetize your properties if you can (though not a coding standard for Drupal).
• The spacing on your form elements in interswitch_donate.inc are spaced too far. lines 88-136 have 4 spaces. There should only be two.
• The tabs should only be two spaces on line 209 - 214.
• Spacing 495 - 498
• Spacing 555 and 556
• Spacing 644 - 646

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.