#1778122-95: Enable modules to inject attributes into field formatters, so that RDF attributes get output showed that the test upgrade ends up creating an EntityDisplay object that contains data for test_deleted_field

We should make sure entity displays do not get populated with fiedls that are deleted at the time the upgrade runs.

Files: 
CommentFileSizeAuthor
#3 entity_display_update-2089273-3-test-only.patch1.35 KByched
FAILED: [[SimpleTest]]: [MySQL] 58,759 pass(es), 2 fail(s), and 0 exception(s).
[ View ]
#3 entity_display_update-2089273-3.patch4.71 KByched
PASSED: [[SimpleTest]]: [MySQL] 59,209 pass(es).
[ View ]
#3 interdiff.txt497 bytesyched
#1 entity_display_update-2089273-1-test-only.patch1.36 KByched
FAILED: [[SimpleTest]]: [MySQL] 59,169 pass(es), 3 fail(s), and 0 exception(s).
[ View ]
#1 entity_display_update-2089273-1.patch4.72 KByched
FAILED: [[SimpleTest]]: [MySQL] 58,075 pass(es), 28 fail(s), and 28 exception(s).
[ View ]

Comments

Status:Active» Needs review
StatusFileSize
new4.72 KB
FAILED: [[SimpleTest]]: [MySQL] 58,075 pass(es), 28 fail(s), and 28 exception(s).
[ View ]
new1.36 KB
FAILED: [[SimpleTest]]: [MySQL] 59,169 pass(es), 3 fail(s), and 0 exception(s).
[ View ]

Should fix it - diff is big, but this just wraps code in an if (instance is not deleted) {

Status:Needs review» Needs work

The last submitted patch, entity_display_update-2089273-1.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new497 bytes
new4.71 KB
PASSED: [[SimpleTest]]: [MySQL] 59,209 pass(es).
[ View ]
new1.35 KB
FAILED: [[SimpleTest]]: [MySQL] 58,759 pass(es), 2 fail(s), and 0 exception(s).
[ View ]

Silly.

Status:Needs review» Reviewed & tested by the community

Status:Reviewed & tested by the community» Needs review

Just a question, does the d7-filled-db or whatever it is actually have deleted fields in it? In other words, are those added tests actually testing anything?

Status:Needs review» Reviewed & tested by the community

Yes it does - or the test-only patch would't fail :-)

Status:Reviewed & tested by the community» Fixed

Duh. :P Right. :P

Committed and pushed to 8.x. Thanks! Yay better upgrade path! :)

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue summary:View changes

more specific