Sitewide, but not admin theme condition [#2089925]

I've been running into a lot of performance issues (some fixed now) where context doing too much work in the 'reaction' part, particularly when viewing the admin theme. The latest one is #2088351: Dont render blocks for regions that aren't REGIONS_VISIBLE. Maybe i'm approaching this wrong... Is there an easy way to have a sitewide condition that only triggers when users are browsing the site, not when users are admnistering the site?

Comment	File	Size	Author
#5	context-sitewide_non_admin_condition-2089925-5.patch	2.3 KB	joelcollinsdc
#5
#4	context-sitewide_non_admin_condition-2089925-4.patch	2.34 KB	iKb
#4
#2	context-sitewide_non_admin_condition-2089925-2.patch	2.31 KB	tekante
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

tekante CreditAttribution: tekante commented 27 September 2013 at 03:51

Would a combination of require all conditions with a sitewide condition along with a path condition of
~admin/*
~node/*/edit
work for what you are trying to accomplish? I think if implementing this as an official condition it would want to make use of something like !path_is_admin(current_path()) in the check.

Comment #2

tekante CreditAttribution: tekante commented 27 September 2013 at 04:43

File	Size
context-sitewide_non_admin_condition-2089925-2.patch	2.31 KB

Attached is a sample patch of how the sitewide context condition might be modified to provide admin and non admin conditions in addition to the current always active condition.

Comment #3

joelcollinsdc CreditAttribution: joelcollinsdc commented 27 September 2013 at 13:40

Assigned:	Unassigned	» joelcollinsdc
Status:	Active	» Needs review

sweet

Comment #4

iKb CreditAttribution: iKb commented 11 October 2013 at 18:24

File	Size
context-sitewide_non_admin_condition-2089925-4.patch	2.34 KB

Just added a condition to #2 to avoid warning

'#default_value' => isset($value['sitewide']) ? $value['sitewide'] : 0,

Comment #5

joelcollinsdc CreditAttribution: joelcollinsdc commented 21 October 2013 at 11:34

Assigned:

joelcollinsdc

» Unassigned

File	Size
context-sitewide_non_admin_condition-2089925-5.patch	2.3 KB

I changed the array index from 'sidewide' back to 1 to allow for backwards compatability with existing contexts. Basically, if this gets renamed to 'sidewide', all existing sitewide conditions will break.

Let me know what yall think. I've tested, it works great otherwise