Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Background:
This issue is part of the task to update the hook_help texts of the Drupal 8 modules:
#1908570: [meta] Update or create hook_help() texts for D8 core modules
Tasks:
- review / write the hook_help text according to help guidelines
Comment | File | Size | Author |
---|---|---|---|
#7 | update-hook-help-for-statistics-2091419-7.patch | 3.53 KB | batigolix |
#5 | update-hook-help-for-statistics-2091419-5.patch | 4 KB | batigolix |
Comments
Comment #1
berkas1 CreditAttribution: berkas1 commentedTaking it... Drupalcon Prague
Comment #2
jhodgdonLooks like it didn't get done.... berkas1 -- if you still want to make a patch, please assign this issue to yourself. Otherwise, it's open for anyone. Thanks!
Comment #3
TR CreditAttribution: TR commentedhook_help() exists for the Statistics modules, just needs to be updated.
Comment #4
batigolixGivin it a shot
Comment #5
batigolixPatch:
- changes refernce to online docs
- changes url token
- changes ulr() -> \Drupal::\\url()
The help text was already reviewed for D8 as part of this issue: #1446956: Remove the accesslog from statistics
To do:
The text contains a link to anchor on the permissions page.
The 'fragment' doe not seem to work.
Comment #6
jhodgdonIt looks like the fragment needs to be in the 3rd parameter:
Other than that, looks good!... Oh, there is still one use of url() -- the last line of the patch.
Comment #7
batigolixThis patch fixes the fragment.
I removed this from the patch:
So that should be dealt with in another issue. (e.g. a UI text review)
Comment #8
batigolixComment #10
jhodgdon7: update-hook-help-for-statistics-2091419-7.patch queued for re-testing.
Comment #11
jhodgdonOK. This is looking good. Ready for a manual test that all the links work (which is all that is changing in this patch). (The test failures seemed to be a general failure of the test bot, so I expect they'll pass this time.)
Oh, and someone needs to give it one more check to make sure all the page names, etc. appearing in the help text still match what you actually see when administering the site.
Comment #12
batigolixComment #13
jhodgdonI gave this a manual test today and it is all working fine.
Comment #14
jhodgdonThere's an "avoid commit conflicts" issue touching statistics.module, so I'm going to be extra-careful and wait to commit this until it's taken care of:
#1996238: Replace hook_library_info() by *.libraries.yml file
Comment #15
jhodgdonI got leave from the other issue people to commit this, so it's in -- committed to 8.x. Thanks again!
Comment #16
jhodgdonFollow-up:
#2199869: Statistics help on admin/config/stystem/statistics has broken link