Not a major issue but just keep having to put them in manually when working on omega theme itself.

CommentFileSizeAuthor
#6 added-guard-livereload-to-the-parent-theme-2092955-3.patch1.82 KBpeteainsworth
#3 added-guard-livereload-to-the-parent-theme-2092955-2.patch1.8 KBpeteainsworth
#1 added-guard-livereload-to-the-parent-theme-2092955-1.patch792 bytespeteainsworth
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

peteainsworth’s picture

peteainsworth CreditAttribution: peteainsworth commented
Status: Active » Needs review
FileSize
added-guard-livereload-to-the-parent-theme-2092955-1.patch792 bytes
fubhy’s picture

fubhy CreditAttribution: fubhy commented
Status: Needs review » Needs work

Well, okay... I did remove that on purpose because back then we did not do any CSS in Omega directly other than the core override stuff (which was already finished) but now with the layouts I guess we can add it back and simply keep it...

However, if you add back the guard gems, I am sure you also want to add Guardfile ;).

peteainsworth’s picture

peteainsworth CreditAttribution: peteainsworth commented
FileSize
added-guard-livereload-to-the-parent-theme-2092955-2.patch1.8 KB

Oh yeah, I forgot that I'd restored the Guardfile :-)

peteainsworth’s picture

peteainsworth CreditAttribution: peteainsworth commented
Status: Needs work » Needs review
fubhy’s picture

fubhy CreditAttribution: fubhy commented
Status: Needs review » Needs work

The patch is corrupt. How are you doing your diff? Your last patch was corrupt too.

peteainsworth’s picture

peteainsworth CreditAttribution: peteainsworth commented
FileSize
added-guard-livereload-to-the-parent-theme-2092955-3.patch1.82 KB

I just used the patch create feature in EGit. It's probably a line ending issue. I've create this one on the CLI so it should be fine.

peteainsworth’s picture

peteainsworth CreditAttribution: peteainsworth commented
Status: Needs work » Needs review
fubhy’s picture

fubhy CreditAttribution: fubhy commented
Status: Needs review » Fixed

Thanks, committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.