Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Needs to be updated following #2074037: Add drupalPostUrl() — drupalPost()/drupalPostAjax() are for forms only, D8 JS performs non-form HTTP requests
| Comment | File | Size | Author |
|---|---|---|---|
| #24 | re-enable-test.patch | 796 bytes | Gábor Hojtsy |
| #22 | configformtestfail-fix.patch | 10.2 KB | Gábor Hojtsy |
| #12 | configformtestfail.patch | 10 KB | tstoeckler |
| #6 | configformtestfail.patch | 10 KB | Gábor Hojtsy |
| drupalpostform.patch | 9.41 KB | Gábor Hojtsy | |
Comments
Comment #1
Gábor HojtsyComment #3
Gábor HojtsyThere are two more fail types due to core changes:
1. Seems like picture mappings cannot be created anymore in the simple way we have in the test, we need a breakpoint group.
2. Contact category titles are not applied to the displayed contact form anymore (which sounds like regression).
The above cannot be committed until we fix these two because testbot will not test any more patches out of a 8.x-1.x branch failing state. :/
Comment #4
Gábor HojtsyComment #5
Gábor Hojtsy#2093027: Regression: contact category titles not used for page title anymore opened for contact.
Comment #6
Gábor HojtsyThis includes a simple fix for the picture formats, enabled toolbar, so a breakpoint group is created by that. We also need #2093027: Regression: contact category titles not used for page title anymore land for this to pass, but now should only fail on contact categories.
Comment #8
Gábor Hojtsy#6: configformtestfail.patch queued for re-testing.
Comment #10
dawehner#6: configformtestfail.patch queued for re-testing.
Comment #12
tstoecklerRe-uploading patch, since the core issue went in.
Comment #13
tstoecklerAlso tagging.
Comment #15
tstoecklerI'm looking at the test fails now. Not assigning yet, as I'm not sure I'll find anything of use...
Comment #16
tstoecklerI'm getting some errors in the contact category UI, so it seems there is in fact something for me to fix here.
Comment #17
tstoecklerSo the notices that I had were bogus (I was trying to create a translation for a language I hadn't added yet).
But I can reproduce the problem the test fails on. When you have a translated contact category, the site title is not the translated contact label, but the English one. That's because the contact category object you get is in fact the English one, not the one with the different langcode. I'm not yet sure why that is.
Comment #18
tstoecklerUnblocking this for now.
Comment #19
Gábor HojtsyI think the config translation for contact categories are failing because the entity is loaded in the request upcasting before the language is made active in the request :/
Comment #20
tstoecklerHopefully the tests will magically be fixed by #2094797: Config entities upcast from the request always get default language context
Comment #21
webflo CreditAttribution: webflo commentedThe patch from #3 works with #2094797.
Comment #22
Gábor HojtsyNow includes workaround for core bug so we can move on until that is fixed.
Comment #23
Gábor HojtsyCommited this. We should remove the @todos later on when #2094797: Config entities upcast from the request always get default language context lands.
Comment #24
Gábor HojtsyShould now pass again :) #2094797: Config entities upcast from the request always get default language context got committed!
Comment #25
Gábor HojtsyYay, this test is now back in action!