i'm using entity_translation combined with OG and VBO and a big user database. When i try perform an VBO action on my OG group, my server uses very much memory.

I've used xhprof for debugging an figured that the function entity_translation_current_form_get_handler() is called quite often form the same (VBO) form. My first and only solution is to set a static on the function.

CommentFileSizeAuthor
#7 static_entity_translation_current_form_get_handler-2093773-7.patch1 KBAnonymous (not verified)
#3 static_entity_translation_current_form_get_handler-2093773-3.patch1 KBAnonymous (not verified)
#1 static_entity_translation_current_form_get_handler-2093773-1.patch1 KBAnonymous (not verified)
after entity_translation_current_form_get_handler.png79.4 KBAnonymous (not verified)
after overal.png27.83 KBAnonymous (not verified)
before entity_translation_current_form_get_handler.png77.91 KBAnonymous (not verified)
before_overal.png27.81 KBAnonymous (not verified)
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Anonymous’s picture

Status: Active » Needs review
FileSize
1 KB

and here's the patch

Status: Needs review » Needs work
Anonymous’s picture

Version: 7.x-1.0-beta3 » 7.x-1.x-dev
FileSize
1 KB

Hmm.. patch #2 was made for beta3..

This one is for the current HEAD.

Anonymous’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work
Anonymous’s picture

Status: Needs work » Needs review
Anonymous’s picture

Almost the same as #3 but return value is now preset..

plach’s picture

Status: Needs review » Postponed (maintainer needs more info)

entity_translation_current_form_get_handler() is no longer used in the current 7.x-1.x HEAD. Can you check whether you still need this optimization?

plach’s picture

Issue summary: View changes

updating description

grahamC’s picture

We've been running into the same problem when using DraggableViews to update the ordering of nodes. Saving the order of ~100 nodes with multiple translations needed about 2.5GB of memory!

I've just tried the latest -dev (2013-Oct-25), and that seems to resolve it here.