Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
- using wetkit theme
- Un-select Logo from the option in Global theme settings (admin/appearance/settings)
- go to home page
- logo still displayed
- switch to bartik theme
- logo is gone as expected
Comment | File | Size | Author |
---|---|---|---|
#2 | logoalwayson.PNG | 73.44 KB | mxlav |
#2 | nologospace.PNG | 9.87 KB | mxlav |
Comments
Comment #1
sylus CreditAttribution: sylus commentedI believe instead you should go to appearance/settings/wetkit_ember
You are adjusting the global settings which won't interact with our theme due to the way we are handling svg.
Try adjusting the settings there and can reopen an issue if a problem.
Comment #2
mxlav CreditAttribution: mxlav commentedstill doesn't seem to work properly.
I even unselected "Use the default logo", and the logo is still there (screenshot)
Then I went to setting/wetkit_omega and unselected the "Use the default logo", the logo finally dissepears but the Site Name doesn't re-align to the left. (screenshot)
Inspecting the element has the follwing css
Comment #3
sylus CreditAttribution: sylus commentedThis should be fixed by the following commit: 5cd81dc
Right now only the WxT theme has the full solution in, so please confirm with that theme.
Once I get the all clear I apply the logic to the other themes.
Comment #4
mxlav CreditAttribution: mxlav commentedNot sure what the expected behaviour is suppose to be..but did the following tests
Test#1
Test#2
Comment #5
sylus CreditAttribution: sylus commentedShould be fixed by: http://drupalcode.org/project/wetkit_omega.git/commit/9d406d2
I don't think we should add this support to internet + intranet as the logo should always be present for these themes.
Comment #7
mxlav CreditAttribution: mxlav commentedthese changes don't seem to be in rc26? Did they get dropped?
Comment #8
joseph.olstadno comment
Comment #9
sylus CreditAttribution: sylus commentedThis should do it and cleans up a bit of the internal logic as well handling this.
Commit: http://drupalcode.org/project/wetkit_omega.git/commit/4c72796