• using wetkit theme
  • Un-select Logo from the option in Global theme settings (admin/appearance/settings)
  • go to home page
  • logo still displayed
  • switch to bartik theme
  • logo is gone as expected
CommentFileSizeAuthor
#2 logoalwayson.PNG73.44 KBmxlav
#2 nologospace.PNG9.87 KBmxlav
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sylus’s picture

Status: Active » Closed (works as designed)

I believe instead you should go to appearance/settings/wetkit_ember

You are adjusting the global settings which won't interact with our theme due to the way we are handling svg.

Try adjusting the settings there and can reopen an issue if a problem.

mxlav’s picture

Status: Closed (works as designed) » Active
FileSize
9.87 KB
73.44 KB

still doesn't seem to work properly.

I even unselected "Use the default logo", and the logo is still there (screenshot)
Then I went to setting/wetkit_omega and unselected the "Use the default logo", the logo finally dissepears but the Site Name doesn't re-align to the left. (screenshot)

Inspecting the element has the follwing css

#wet-title span {
display: table-cell;
vertical-align: middle;
padding-left: 155px;
height: 2.82em;
sylus’s picture

Status: Active » Needs review

This should be fixed by the following commit: 5cd81dc

Right now only the WxT theme has the full solution in, so please confirm with that theme.

Once I get the all clear I apply the logic to the other themes.

mxlav’s picture

Version: 7.x-1.x-dev » 7.x-1.0-rc15

Not sure what the expected behaviour is suppose to be..but did the following tests

Test#1

  • admin/appearance/settings/wetkit_omega
  • under toggle display, uncheck logo
  • save config
  • Logo still there

Test#2

  • admin/appearance/settings/wetkit_omega
  • restore original settings
  • under logo image settings, use default logo is already unchecked as per changes in the above patch
  • uncheck use SVG logo
  • save config
  • logo is gone, but padding remains
#wet-title span {
display: table-cell;
vertical-align: middle;
padding-left: 155px;
height: 2.82em;
}
sylus’s picture

Status: Needs review » Fixed

Should be fixed by: http://drupalcode.org/project/wetkit_omega.git/commit/9d406d2

I don't think we should add this support to internet + intranet as the logo should always be present for these themes.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

mxlav’s picture

Version: 7.x-1.0-rc15 » 7.x-1.0-rc26
Issue summary: View changes
Status: Closed (fixed) » Needs review

these changes don't seem to be in rc26? Did they get dropped?

joseph.olstad’s picture

no comment

sylus’s picture

Status: Needs review » Fixed

This should do it and cleans up a bit of the internal logic as well handling this.

Commit: http://drupalcode.org/project/wetkit_omega.git/commit/4c72796

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.