The view modes for entities except Content (node) are displayed in a non-understandable order. This happens during actual theme rendering, as the render array appears normal.

CommentFileSizeAuthor
#9 0001-Issue-2094873-by-fgm-entity-view-modes-were-displaye.patch8.9 KBfgm
#8 0001-Issue-2094873-by-fgm-entity-view-modes-were-displaye.patch1.25 KBfgm
#5 2094873-fail-5.patch916 bytesswentel
#5 2094873-pass-5.patch1.79 KBswentel
#1 0001-Issue-2094873-by-fgm-entity-view-modes-were-displaye.patch1.25 KBfgm
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

fgm’s picture

fgm
Primary language French
Location Paris, France
CreditAttribution: fgm commented
Status: Active » Needs review
FileSize
0001-Issue-2094873-by-fgm-entity-view-modes-were-displaye.patch1.25 KB

Suggested patch reorders by entity name.

Also, the "Content" (node) view modes are listed first by an explicit choice in code without any user-level explanation, which seems weird in terms of UX, but since this is an explicit choice, the patch doesn't change this.

fgm’s picture

fgm
Primary language French
Location Paris, France
CreditAttribution: fgm commented
Title: The view modes page displays out of order » The view modes pages (form, view) both display out of order

The patch fixes both pages.

swentel’s picture

swentel CreditAttribution: swentel commented
Status: Needs review » Reviewed & tested by the community

Makes sense indeed.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs tests

I'm guessing we should have a test for this then

swentel’s picture

swentel CreditAttribution: swentel commented
Status: Needs work » Needs review
Issue tags: -Needs tests
FileSize
2094873-pass-5.patch1.79 KB
2094873-fail-5.patch916 bytes
fgm’s picture

fgm
Primary language French
Location Paris, France
CreditAttribution: fgm commented
Status: Needs review » Needs work
Issue tags: +Needs tests

Actually, I wrote a test and allowed me to catch another error situation which my original patch does not cover, so I've started restructuring a bit more and using ConfigEntityBase::sort() for entity types ordering.

So I'm marking "needs work" even though swentel's test completes my original patch.

swentel’s picture

swentel CreditAttribution: swentel commented

@fgm are you still working on this ?

fgm’s picture

fgm
Primary language French
Location Paris, France
CreditAttribution: fgm commented
Issue summary: View changes
Status: Needs work » Needs review
FileSize
0001-Issue-2094873-by-fgm-entity-view-modes-were-displaye.patch1.25 KB

Oops, I has completely forgotten about that one. Rerolled the failing test on top of current HEAD: it is expected to fail because it demonstrates the bug. I resumed work on the actual fix this morning.

fgm’s picture

fgm
Primary language French
Location Paris, France
CreditAttribution: fgm commented
FileSize
0001-Issue-2094873-by-fgm-entity-view-modes-were-displaye.patch8.9 KB

Rerolled on this afternoon's HEAD. Still not working but fresher than the one in #8.

Status: Needs review » Needs work

The last submitted patch, 9: 0001-Issue-2094873-by-fgm-entity-view-modes-were-displaye.patch, failed testing.

Status: Needs work » Needs review

fgm queued 9: 0001-Issue-2094873-by-fgm-entity-view-modes-were-displaye.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 9: 0001-Issue-2094873-by-fgm-entity-view-modes-were-displaye.patch, failed testing.

fgm’s picture

fgm
Primary language French
Location Paris, France
CreditAttribution: fgm at OSInet commented
Status: Needs work » Fixed

This has been fixed at some point since the last patch. Marking as such.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.