As seen here, https://drupal.org/node/718414#comment-6092686 the Feeds integration leaves something to be desired. Fix to come once I get an issue number.

CommentFileSizeAuthor
#1 email-fix-feeds-integration-2095197-1.patch1.6 KBtwistor
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

twistor’s picture

twistor CreditAttribution: twistor commented
Status: Active » Needs review
FileSize
email-fix-feeds-integration-2095197-1.patch1.6 KB

This brings things up to modern Feeds standards without breaking backwards compatibility.

twistor’s picture

twistor CreditAttribution: twistor commented
  1. I removed the param docs since it's a documented callback, and they were wrong anyway.
  2. I removed the cardinality check since field.module will do that for us.
  3. Added support for FeedsElement.
  4. Added validation.
  5. Also added support for being able to map multiple sources to the same field target.
twistor’s picture

twistor CreditAttribution: twistor commented
Issue summary: View changes

typo

AdamGerthel’s picture

AdamGerthel CreditAttribution: AdamGerthel commented
Issue summary: View changes

Tested it, looks good from a functionality standpoint - haven't reviewed the code.

troybthompson’s picture

troybthompson CreditAttribution: troybthompson commented

I don't know the specific goals, but this solved my problem of blank e-mail fields still getting rendered. I'm still getting duplicate entries in the database, though when imported multiple times.

AdamPS’s picture

AdamPS CreditAttribution: AdamPS commented
Status: Needs review » Reviewed & tested by the community

Code works for me. Would be helpful to have this one committed.