Updated: Comment #0

Problem/Motivation

In #2087231: Add a PluginBase in the Core namespace with t() as a helper method we added method t() to PluginBase. So, it's no longer needed in LocalTaskDefault

Proposed resolution

Removed the t() method and stop injecting the translation manager.

Remaining tasks

N/A

User interface changes

N/A

API changes

N/A

Follow-up from #2087231: Add a PluginBase in the Core namespace with t() as a helper method.

Files: 
CommentFileSizeAuthor
#4 local-task-2095223-4.patch3.62 KBtim.plunkett
PASSED: [[SimpleTest]]: [MySQL] 58,702 pass(es).
[ View ]
#4 interdiff.txt1.11 KBtim.plunkett
#1 2095223-1.patch2.51 KBpwolanin
FAILED: [[SimpleTest]]: [MySQL] 58,456 pass(es), 10 fail(s), and 0 exception(s).
[ View ]

Comments

Priority:Major» Normal
Status:Active» Needs review
Issue tags:-Needs change record+MenuSystemRevamp, +WSCCI
StatusFileSize
new2.51 KB
FAILED: [[SimpleTest]]: [MySQL] 58,456 pass(es), 10 fail(s), and 0 exception(s).
[ View ]

Simple patch.

Status:Needs review» Reviewed & tested by the community

I double checked all other plugin classes, none of them had yet added their own $this->t() yet, this was the only one.

Status:Reviewed & tested by the community» Needs work

Next time lets better run unit tests ...

Status:Needs work» Needs review
StatusFileSize
new1.11 KB
new3.62 KB
PASSED: [[SimpleTest]]: [MySQL] 58,702 pass(es).
[ View ]

Duh! @dawehner++

Status:Needs review» Reviewed & tested by the community

bam, lets do that.

Status:Reviewed & tested by the community» Fixed

Committed 3210323 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.