Provide config schema for Form modes [#2096371]

This is a sub-issue of #1910624: [META] Introduce and complete configuration schemas in all of core.

Problem/motivation

#1866610: Introduce Kwalify-inspired schema format for configuration introduced some config schema coverage for views, but it is not complete. The changelog leads to (hopefully extensive) documentation on the format at http://drupal.org/node/1905070. While there are little cleanups planned for the format overall, the current format is a result of months of back and forths, so it should be perfectly fine to apply it more widely to core.

Proposed solution

Figure out the missing pieces that are not yet covered. Write schema file sections for them. Clean up / fix any issues in current schema.

Create a configuration schema for entity type form_mode.

Comment	File	Size	Author
#14	2096371-form_mode-config-schema-14.patch	1.49 KB	vijaycs85
#14
#10	form_mode_entity_schema-2096371-10.patch	1.23 KB	sushantpaste
#10
#8	form_mode_entity_schema-2096371-8.patch	1.28 KB	sushantpaste
#8
#6	form_mode_entity_schema-2096371-5.patch	841 bytes	siva_epari
#6
#4	configuration editor form.png	24.02 KB	siva_epari
#4	form_mode_entity_schema-2096371-4.patch	841 bytes	siva_epari
#4
#2	configuration editor form.png	26.45 KB	jsbalsera
#2	form_mode_entity_schema-2096371-3.patch	1 KB	jsbalsera
#2
#2	interdiff.txt	754 bytes	jsbalsera
#1	configuration editor form.png	22.23 KB	jsbalsera
#1	raw.png	9.66 KB	jsbalsera
#1	form_mode_entity_schema-2096371-2.patch	1 KB	jsbalsera
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

jsbalsera

he/his

Spanish

Córdoba, Spain

CreditAttribution: jsbalsera commented 28 September 2013 at 19:39

Status:

Active

» Needs review

File	Size
form_mode_entity_schema-2096371-2.patch	1 KB

raw.png	9.66 KB
configuration editor form.png	22.23 KB

Raw data:

Form tab in the config inspector form view:

configuration editor form.png

Comment #2

jsbalsera

he/his

Spanish

Córdoba, Spain

CreditAttribution: jsbalsera commented 28 September 2013 at 20:27

File	Size
interdiff.txt	754 bytes
form_mode_entity_schema-2096371-3.patch	1 KB

configuration editor form.png	26.45 KB

There was a typo
configuration editor form.png

Comment #3

vijaycs85

London, UK

CreditAttribution: vijaycs85 commented 13 October 2013 at 15:37

+++ b/core/modules/entity/config/schema/entity.schema.yml
@@ -0,0 +1,27 @@
+# Configuration schema for entity type entity_display

entity_display?

+++ b/core/modules/entity/config/schema/entity.schema.yml
@@ -0,0 +1,27 @@
+      label: 'Entity type this form or view mode is used for'
...
+      label: 'Whether or not this form or view mode has custom settings by default'
...
+      label: 'Whether or not the rendered output of this view mode is cached by default'

Not sure about this labels. may need to make them bit short?

Comment #4

siva_epari CreditAttribution: siva_epari commented 10 November 2013 at 10:37

Issue summary:

View changes

File	Size
form_mode_entity_schema-2096371-4.patch	841 bytes

configuration editor form.png	24.02 KB

Removed the top comment & renamed labels of status as 'Status' and for cache as 'Cache'

Drupal Configuration editor

Comment #5

10 November 2013 at 07:49

Status:

Needs review

» Needs work

The last submitted patch, 4: form_mode_entity_schema-2096371-4.patch, failed testing.

Comment #6

siva_epari CreditAttribution: siva_epari commented 10 November 2013 at 08:33

File	Size
form_mode_entity_schema-2096371-5.patch	841 bytes

The previous patch was not a proper git patch. Reuploading proper patch.

Drupal Configuration editor

Comment #7

siva_epari CreditAttribution: siva_epari commented 10 November 2013 at 08:49

Status:

Needs work

» Needs review

Comment #8

sushantpaste

Marathi

Sawantwadi India

CreditAttribution: sushantpaste commented 15 November 2013 at 11:02

File	Size
form_mode_entity_schema-2096371-8.patch	1.28 KB

@Siva : patch seems to work fine. Checked with config inspector.
Here are small modification in patch with comment and label.

Comment #9

vijaycs85

London, UK

CreditAttribution: vijaycs85 commented 16 November 2013 at 00:01

Thanks for your work on this issue @sushantpaste and @epari.siva. Here is some minor review comments.

```
+++ b/core/modules/entity/config/schema/entity.schema.yml
@@ -0,0 +1,26 @@
+# Configuration schema for entity type form_mode
```
we may need to update title... how about 'Configuration schema for form mode of entities' or Configuration schema for the entity form mode'

+++ b/core/modules/entity/config/schema/entity.schema.yml
@@ -0,0 +1,26 @@
\ No newline at end of file

Needs a empty line at the end.

Comment #10

sushantpaste

Marathi

Sawantwadi India

CreditAttribution: sushantpaste commented 18 November 2013 at 07:56

File	Size
form_mode_entity_schema-2096371-10.patch	1.23 KB

@vijaycs85: Thanks for the review. Here is updated patch.

Comment #11

vijaycs85

London, UK

CreditAttribution: vijaycs85 commented 29 November 2013 at 14:11

Status:

Needs review

» Reviewed & tested by the community

Thanks again @sushantpaste.

+++ b/core/modules/entity/config/schema/entity.schema.yml
@@ -0,0 +1,26 @@
+      label: 'The human-readable name of the form or view mode'
...
+      label: 'Used for Entity type'

these labels are looks bit wired. But they are not really show stoppers.

Comment #12

sushantpaste

Marathi

Sawantwadi India

CreditAttribution: sushantpaste commented 30 November 2013 at 09:50

@vijaycs85: should we change that labels ?

Comment #13

webchick

she/they

English

Vancouver 🇨🇦

CreditAttribution: webchick commented 4 December 2013 at 06:04

Assigned:	Unassigned	» vijaycs85
Status:	Reviewed & tested by the community	» Needs review

'Used for Entity type' definitely sounds weird to me, but I'm not that familiar with form modes. Marking back to needs review for vijay.

Comment #14

vijaycs85

London, UK

CreditAttribution: vijaycs85 commented 4 December 2013 at 17:38

File	Size
2096371-form_mode-config-schema-14.patch	1.49 KB

Re-rolling + label changes: As there is no UI for the fields in this schema, just using the human readable form of key as label.

Comment #15

vijaycs85

London, UK

CreditAttribution: vijaycs85 commented 8 December 2013 at 17:14

Assigned:

vijaycs85

» Unassigned

Comment #16

ianthomas_uk

he/him

English

Brighton, UK

CreditAttribution: ianthomas_uk commented 8 December 2013 at 18:15

vijaycs85's changes are a little more than #14 suggests, becuase very similar code has already been committed. His new patch updated the labels for the patch on #10 and the code that was already committed.