Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Thanks for your Adsense module and it's very useful and easy to use, especial for by block.
Now I am using block to setup the adsense code but when I check the page code, I find the id is id="jcv block--managed-2", it's strange that the id have two value.
I just setup the #block--managed-2 property to "width=160px; height=600px" but it can't work. When I delete jcv by firebug, then it works very well. So how we should delete the jcv, please?
Comment | File | Size | Author |
---|---|---|---|
#4 | adsense-managed_block_id-2097267-4.patch | 978 bytes | revagomes |
Comments
Comment #1
WebDux.com CreditAttribution: WebDux.com commentedI just delete the "jcv" code from block--adsense_managed.tpl.php and it's ok now. What the jcv means, please?
Comment #2
jcnventura CreditAttribution: jcnventura commented'jcv' are my initials.. That's certainly a debug id that I forgot to remove.. Sorry.
Comment #3
cimo75 CreditAttribution: cimo75 commentedHi
this should be removed asap because having more than one ID on an element is out of html specs, many browsers won t read the proper css property with that extra ID in.
Simone
Comment #4
revagomes CreditAttribution: revagomes commentedI faced this problem about a minute ago.
Here goes a patch to fix this issue.
Comment #5
jcnventura CreditAttribution: jcnventura commentedSorry for the delay on fixing this. It's now in git.
http://drupalcode.org/project/adsense.git/commit/34edeec
Comment #6
revagomes CreditAttribution: revagomes commentedIt's awesome that its already committed! Thanks!
I'm just sad about my effort to find an issue related to it, clone the repo locally, fix the issue, create a patch an publish it back to the community wasn't recognized by co-authoring the commit. :/
@see Commit messages - providing history and credit
Comment #7
cimo75 CreditAttribution: cimo75 commentedAn unjust world, that s what it is
Comment #8
jcnventura CreditAttribution: jcnventura commented@revagomes: sorry for not crediting you, but deleting 4 chars is hardly worth the effort to do all that.. Also, I had alredy removed the "jcv " a long, long time ago.. I just hadn't committed it yet.
Comment #9
revagomes CreditAttribution: revagomes commentedThat was the reason why I wasted my time creating this patch. ;)
It's not a problem to me anyway.
I'm just pointing that contributions are made by people that are spending their time to improve something. This should be always recognized even if the contribution is just a simple fix that wasn't commited for a long time...
Again, it's not a problem to me anyway. Thanks for the commit ;)