The test block appears in the custom category.
Other
DisplayBlockTest.php
102
Drupal\block\Tests\Views\DisplayBlockTest->testBlockCategory()
The second cloned test block appears in the custom category.
Other
DisplayBlockTest.php
120
Drupal\block\Tests\Views\DisplayBlockTest->testBlockCategory()
Files: 
CommentFileSizeAuthor
#15 drupal-2097537-15.patch4.78 KBolli
PASSED: [[SimpleTest]]: [MySQL] 58,751 pass(es).
[ View ]
#15 interdiff.txt1.65 KBolli
#12 2097537-12-random-fail.patch816 bytesolli
FAILED: [[SimpleTest]]: [MySQL] 58,804 pass(es), 2 fail(s), and 0 exception(s).
[ View ]
#12 2097537-12-random-pass.patch3.6 KBolli
FAILED: [[SimpleTest]]: [MySQL] 58,432 pass(es), 2 fail(s), and 0 exception(s).
[ View ]
#12 drupal-2097537-12.patch3.13 KBolli
FAILED: [[SimpleTest]]: [MySQL] 58,779 pass(es), 2 fail(s), and 0 exception(s).
[ View ]
#4 block-2097537-4.patch897 bytestim.plunkett
PASSED: [[SimpleTest]]: [MySQL] 58,778 pass(es).
[ View ]
#2 block-2097537-2.patch1.03 KBtim.plunkett
FAILED: [[SimpleTest]]: [MySQL] Setup environment: Test cancelled by admin prior to completion.
[ View ]

Comments

Issue tags:+Random test failure

Tagging.

StatusFileSize
new1.03 KB
FAILED: [[SimpleTest]]: [MySQL] Setup environment: Test cancelled by admin prior to completion.
[ View ]

From form_builder():

  if (!isset($element['#id'])) {
    $element['#id'] = drupal_html_id('edit-' . implode('-', $element['#parents']));
  }

The implode is causes any leading or trailing hyphens to be stripped off before making the ID.

Priority:Normal» Critical
Status:Active» Needs review

Marking this critical because it just "broke" HEAD.

StatusFileSize
new897 bytes
PASSED: [[SimpleTest]]: [MySQL] 58,778 pass(es).
[ View ]

Nevermind, that last assumption was completely wrong, and idk why I thought that. It's just that drupal_html_id() removes consecutive hyphens.

per IRC discussion - that's the wrong fix, instead move 'edit-' . inside the call to drupal_html_id($id)

cross-post - yes, #4 looks like the right fix.

I'm not sure that the String::checkPlain() is actually needed, but clearly it's already in the test.

Status:Needs review» Reviewed & tested by the community

RTBC (assuming the tests pass with the corrected logic).

Issue tags:+VDC

Finally @tim.plunkett created the issue :P. RTBC +1

Status:Reviewed & tested by the community» Fixed

Committed 34f638b and pushed to 8.x. Thanks!

Priority:Critical» Major
Status:Fixed» Active

Berdir found yet another random fail in the same place, but much less common...

Status:Active» Needs review
StatusFileSize
new3.13 KB
FAILED: [[SimpleTest]]: [MySQL] 58,779 pass(es), 2 fail(s), and 0 exception(s).
[ View ]
new3.6 KB
FAILED: [[SimpleTest]]: [MySQL] 58,432 pass(es), 2 fail(s), and 0 exception(s).
[ View ]
new816 bytes
FAILED: [[SimpleTest]]: [MySQL] 58,804 pass(es), 2 fail(s), and 0 exception(s).
[ View ]

Categories like "#random" are not visible on the block placement page.

Issue tags:+VDC, +Random test failure

The last submitted patch, drupal-2097537-12.patch, failed testing.

Status:Needs review» Needs work
Issue tags:-VDC, -Random test failure

The last submitted patch, drupal-2097537-12.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new1.65 KB
new4.78 KB
PASSED: [[SimpleTest]]: [MySQL] 58,751 pass(es).
[ View ]

Status:Needs review» Reviewed & tested by the community

Thanks... This has been awful :)

Status:Reviewed & tested by the community» Fixed

Wow, great find!

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.