The parseDependency method does not belong into the ModuleHandler. It's a general utility thing. And while we are at it we can just as well move the checkIncompatibility method over as well.

Files: 
CommentFileSizeAuthor
#7 drupal8.base-system.2098521-7.patch11.93 KBfubhy
PASSED: [[SimpleTest]]: [MySQL] 58,647 pass(es).
[ View ]
#1 drupal8.base-system.2098521-1.patch7.85 KBfubhy
FAILED: [[SimpleTest]]: [MySQL] Drupal installation failed.
[ View ]

Comments

Status:Active» Needs review
StatusFileSize
new7.85 KB
FAILED: [[SimpleTest]]: [MySQL] Drupal installation failed.
[ View ]

Status:Needs review» Needs work

The last submitted patch, drupal8.base-system.2098521-1.patch, failed testing.

Status:Needs work» Needs review

We already got more than enough crap in ModuleHandler so I really want to get rid of this additional burden. I am going to do some further cleanup in a couple of other issues and this would really help to keep that class clean.

#1: drupal8.base-system.2098521-1.patch queued for re-testing.

Status:Needs review» Needs work

The last submitted patch, drupal8.base-system.2098521-1.patch, failed testing.

Yes, I agree with this issue. The patch is missing the actual file.

Status:Needs work» Needs review
StatusFileSize
new11.93 KB
PASSED: [[SimpleTest]]: [MySQL] 58,647 pass(es).
[ View ]

Yes, I agree with this issue. The patch is missing the actual file.

/facepalm

Is there a reason why this is not part of the extension namespace at least?

Status:Needs review» Needs work

.