Updated: Comment #0

Problem/Motivation

For config_translation.module we need a way to check whether a translation exists for a certain config name. This is only related to the locale override system and is not related to the config translation system in particular, so it should not be added there.

Proposed resolution

Add a "hasTranslation()" utility method to LocaleConfigManager.

Files: 
CommentFileSizeAuthor
#8 2098697-locale-has-translation-8.patch4.56 KBtstoeckler
PASSED: [[SimpleTest]]: [MySQL] 58,827 pass(es).
[ View ]
#8 2098697-locale-has-translation-interdiff-1-8.txt2.4 KBtstoeckler
#6 locale-config-manager-has-translation-2098697-5.patch5.99 KBGábor Hojtsy
FAILED: [[SimpleTest]]: [MySQL] 58,381 pass(es), 14 fail(s), and 2 exception(s).
[ View ]
#5 locale-config-manager-has-translation-2098697-5.patch5.99 KBsxnc
FAILED: [[SimpleTest]]: [MySQL] 59,011 pass(es), 14 fail(s), and 2 exception(s).
[ View ]
#1 locale-config-manager-has-translation.patch5.46 KBtstoeckler
FAILED: [[SimpleTest]]: [MySQL] 58,658 pass(es), 0 fail(s), and 52 exception(s).
[ View ]

Comments

Status:Active» Needs review
StatusFileSize
new5.46 KB
FAILED: [[SimpleTest]]: [MySQL] 58,658 pass(es), 0 fail(s), and 52 exception(s).
[ View ]

Here we go.

Status:Needs review» Needs work

The last submitted patch, locale-config-manager-has-translation.patch, failed testing.

Assigned:Unassigned» sxnc
Issue tags:-D8MI, -sprint, -language-config, -blocker

Status:Needs work» Needs review
Issue tags:+D8MI, +sprint, +language-config, +blocker
StatusFileSize
new5.99 KB
FAILED: [[SimpleTest]]: [MySQL] 59,011 pass(es), 14 fail(s), and 2 exception(s).
[ View ]

StatusFileSize
new5.99 KB
FAILED: [[SimpleTest]]: [MySQL] 58,381 pass(es), 14 fail(s), and 2 exception(s).
[ View ]

Re-uploading for testbot sanity. We need it to return data for us.

Status:Needs review» Needs work

The last submitted patch, locale-config-manager-has-translation-2098697-5.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new2.4 KB
new4.56 KB
PASSED: [[SimpleTest]]: [MySQL] 58,827 pass(es).
[ View ]

I don't think that #5/#6 are the correct fix.

Gábor explained that there's a problem with empty config files because they get imported and also their schema is getting parsed. This seems to be the problem. I've removed those files. So we can't test the hasTranslation() behavior with empty translation files, but we can't have empty translation files without other stuff failing anyway, so I think that's OK.

Sorry @sxnc for taking this over, hope that's OK.

Let's see if that passes.

Status:Needs review» Reviewed & tested by the community

Looks good! Reviewed in person.

@tstoeckler np! i thought i had it fixed but its good to see what the actual problem was, thanks a lot! :)

Status:Reviewed & tested by the community» Needs work

Doesn't seem to apply for me. :(

Status:Needs work» Needs review
Issue tags:-D8MI, -sprint, -language-config, -blocker

Issue tags:+D8MI, +sprint, +language-config, +blocker

Status:Needs review» Reviewed & tested by the community

Still applies/passes with the testbot in the past 2 days. @webchick can you try again? :) Thanks!

Status:Reviewed & tested by the community» Fixed

Huh. No idea what that was about.

Committed and pushed to 8.x. Thanks!

Issue tags:-sprint

Thanks a lot! Woot!

Automatically closed -- issue fixed for 2 weeks with no activity.