This issues shows that comma at the end are not necessary:

#2002726-19: Remove unused local variables from core/includes/menu.inc
#2062213-12: Remove Unused local variable $scheme from /core/lib/Drupal/Core/StreamWrapper/LocalStream.php

so this issue is to clean it up some files and delete the comma.

Files: 
CommentFileSizeAuthor
#6 core-clean-up-list-function-2099347-6.patch2.18 KBruloweb
PASSED: [[SimpleTest]]: [MySQL] 59,077 pass(es).
[ View ]
#3 core-clean-up-list-function-2099347-3.patch2.26 KBruloweb
PASSED: [[SimpleTest]]: [MySQL] 59,318 pass(es).
[ View ]
#1 core-clean-up-list-function-2099347-1.patch2.23 KBruloweb
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch core-clean-up-list-function-2099347-1.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Comments

Status:Active» Needs review
StatusFileSize
new2.23 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch core-clean-up-list-function-2099347-1.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

I found the comma at the end in three files:

core/modules/file/file.views.inc
core/modules/image/image.views.inc
core/modules/taxonomy/taxonomy.views.inc

and created a patch xD

Status:Needs review» Needs work

The last submitted patch, core-clean-up-list-function-2099347-1.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new2.26 KB
PASSED: [[SimpleTest]]: [MySQL] 59,318 pass(es).
[ View ]

Re-rolling.

Status:Needs review» Reviewed & tested by the community

These cleanups make sense to me. Thanks @ruloweb for working on that during the DrupalCon core sprint :)

Status:Reviewed & tested by the community» Needs work
Issue tags:+Quick fix

Nice clean-up!

Unfortunately, no longer applies. I can haz a re-roll? :)

Status:Needs work» Needs review
StatusFileSize
new2.18 KB
PASSED: [[SimpleTest]]: [MySQL] 59,077 pass(es).
[ View ]

Re-rolling again xD.

Status:Needs review» Reviewed & tested by the community

back to RTBC.

Title:Clean up list functionClean up list function usage
Status:Reviewed & tested by the community» Fixed

Committed/pushed to 8.x, thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.