Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
This issues shows that comma at the end are not necessary:
#2002726-19: Remove unused local variables from core/includes/menu.inc
#2062213-12: Remove Unused local variable $scheme from /core/lib/Drupal/Core/StreamWrapper/LocalStream.php
so this issue is to clean it up some files and delete the comma.
Comment | File | Size | Author |
---|---|---|---|
#6 | core-clean-up-list-function-2099347-6.patch | 2.18 KB | ruloweb |
#3 | core-clean-up-list-function-2099347-3.patch | 2.26 KB | ruloweb |
#1 | core-clean-up-list-function-2099347-1.patch | 2.23 KB | ruloweb |
Comments
Comment #1
ruloweb CreditAttribution: ruloweb commentedI found the comma at the end in three files:
core/modules/file/file.views.inc
core/modules/image/image.views.inc
core/modules/taxonomy/taxonomy.views.inc
and created a patch xD
Comment #3
ruloweb CreditAttribution: ruloweb commentedRe-rolling.
Comment #4
scor CreditAttribution: scor commentedThese cleanups make sense to me. Thanks @ruloweb for working on that during the DrupalCon core sprint :)
Comment #5
webchickNice clean-up!
Unfortunately, no longer applies. I can haz a re-roll? :)
Comment #6
ruloweb CreditAttribution: ruloweb commentedRe-rolling again xD.
Comment #7
scor CreditAttribution: scor commentedback to RTBC.
Comment #8
catchCommitted/pushed to 8.x, thanks!