Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ruloweb’s picture

Status: Active » Needs review
FileSize
2.23 KB

I found the comma at the end in three files:

core/modules/file/file.views.inc
core/modules/image/image.views.inc
core/modules/taxonomy/taxonomy.views.inc

and created a patch xD

Status: Needs review » Needs work

The last submitted patch, core-clean-up-list-function-2099347-1.patch, failed testing.

ruloweb’s picture

Status: Needs work » Needs review
FileSize
2.26 KB

Re-rolling.

scor’s picture

Status: Needs review » Reviewed & tested by the community

These cleanups make sense to me. Thanks @ruloweb for working on that during the DrupalCon core sprint :)

webchick’s picture

Status: Reviewed & tested by the community » Needs work
Issue tags: +Quick fix

Nice clean-up!

Unfortunately, no longer applies. I can haz a re-roll? :)

ruloweb’s picture

Status: Needs work » Needs review
FileSize
2.18 KB

Re-rolling again xD.

scor’s picture

Status: Needs review » Reviewed & tested by the community

back to RTBC.

catch’s picture

Title: Clean up list function » Clean up list function usage
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.