When having some tips failing it is good to know how many tips are tested and how many are modal versions. This is esp useful when having modules altering tips and thus tip count.

CommentFileSizeAuthor
#5 drupal8.tour-module.2099471-5.patch1.22 KBclemens.tolboom
#3 drupal8.tour-module.2099471-3.patch1.23 KBclemens.tolboom
#1 drupal8.tour-module.2099471-1.patch1.23 KBclemens.tolboom
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
CreditAttribution: clemens.tolboom commented
Status: Active » Needs review
FileSize
drupal8.tour-module.2099471-1.patch1.23 KB
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented

Needs a . on end of "it's a modal" comment

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
CreditAttribution: clemens.tolboom commented
FileSize
drupal8.tour-module.2099471-3.patch1.23 KB

Added #2.

Can we do better showing hook_tour_tips_alter kicked in? See #2017471: Multilingual tour for language section for our first implementation.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented 
+++ b/core/modules/tour/lib/Drupal/tour/Tests/TourTestBase.php
@@ -60,7 +62,13 @@ class TourTestBase extends WebTestBase {
+      $this->assertTrue(true, format_string('Total %total Tips tested of which %modals modal(s).', array('%total' => $total, '%modals' => $modals)));

Should use $this->pass() instead of $this->assertTrue()

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
CreditAttribution: clemens.tolboom commented
FileSize
drupal8.tour-module.2099471-5.patch1.22 KB

@larowlan thanks

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Status: Needs review » Reviewed & tested by the community

Thanks

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Category: feature » task

Not really a feature, just a useful debug addition

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented
Title: Report the total number and modal tips testen. » Report the total number and modal tips tests

Title fix.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

I'll take your word for it that this is helpful. :)

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.