Updated: Comment #0

Problem/Motivation

This is causing confusion in other issues, like:

so let's just fix it here.

Comment has local tasks in commen_menu(), the implementation of hook_menu(), AND it has a comment.local_tasks.yml.
The route information in comment.local_tasks.yml is being ignored.

Proposed resolution

Fix the routes in comment.local_tasks.yml to use the correct convention of naming routes.
and take out the old redundent stuff from comment_menu()

Remaining tasks

User interface changes

No.

API changes

None?

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

YesCT’s picture

many we should check for more and do them all here... I think the others are 2 other menu_tests and views_ui.

I'll do just comment at first.

#2095271-12: Add default tabs for routes expected by config_translation has background detail.

larowlan’s picture

Issue tags: +Novice
YesCT’s picture

Status: Active » Needs review
FileSize
742 bytes

just the localtask route name change.

YesCT’s picture

in comment.routing.yml:

comment.permalink:
path: '/comment/{comment}'
defaults:
_controller: '\Drupal\comment\Controller\CommentController::commentPermalink'
requirements:
_entity_access: 'comment.view'

comment.edit_page:
path: '/comment/{comment}/edit'
defaults:
_entity_form: 'comment.default'
requirements:
_entity_access: 'comment.update'

comment.confirm_delete:
path: '/comment/{comment}/delete'
defaults:
_entity_form: 'comment.delete'
requirements:
_entity_access: 'comment.delete'

...

taking just those out of comment_menu()

the delete there has weight of 20, and the local_tasks.yml had 10. Let's see what it should be.

YesCT’s picture

Status: Needs review » Closed (duplicate)
YesCT’s picture

Issue summary: View changes

another issue where naming was confusing