Updated: Comment #0
Problem/Motivation
This is causing confusion in other issues, like:
- #2095271: Add default tabs for routes expected by config_translation
- #2095613: Convert all plugin IDs in local_tasks.yml to 'module_name.foo_bar' naming convention to match routing convention
- #2106349: Comment translation overview has broken local tasks
so let's just fix it here.
Comment has local tasks in commen_menu(), the implementation of hook_menu(), AND it has a comment.local_tasks.yml.
The route information in comment.local_tasks.yml is being ignored.
Proposed resolution
Fix the routes in comment.local_tasks.yml to use the correct convention of naming routes.
and take out the old redundent stuff from comment_menu()
Remaining tasks
User interface changes
No.
API changes
None?
Related Issues
- #1981368: Convert all routes to 'module_name.foo_bar' naming convention
- https://drupal.org/node/2044515 is the change notice Local tasks are provided by plugins implementing LocalTaskInterface instead of type MENU_LOCAL_TASK in hook_menu()
- #2095271: Add default tabs for routes expected by config_translation
- #2095613: Convert all plugin IDs in local_tasks.yml to 'module_name.foo_bar' naming convention to match routing convention
Comment | File | Size | Author |
---|---|---|---|
#4 | drupal8.other_.2100213-4.patch | 1.92 KB | YesCT |
#4 | interdiff-2100213-3-4.txt | 1.2 KB | YesCT |
#3 | drupal8.other_.2100213-3.patch | 742 bytes | YesCT |
Comments
Comment #1
YesCT CreditAttribution: YesCT commentedmany we should check for more and do them all here... I think the others are 2 other menu_tests and views_ui.
I'll do just comment at first.
#2095271-12: Add default tabs for routes expected by config_translation has background detail.
Comment #2
larowlanComment #3
YesCT CreditAttribution: YesCT commentedjust the localtask route name change.
Comment #4
YesCT CreditAttribution: YesCT commentedin comment.routing.yml:
comment.permalink:
path: '/comment/{comment}'
defaults:
_controller: '\Drupal\comment\Controller\CommentController::commentPermalink'
requirements:
_entity_access: 'comment.view'
comment.edit_page:
path: '/comment/{comment}/edit'
defaults:
_entity_form: 'comment.default'
requirements:
_entity_access: 'comment.update'
comment.confirm_delete:
path: '/comment/{comment}/delete'
defaults:
_entity_form: 'comment.delete'
requirements:
_entity_access: 'comment.delete'
...
taking just those out of comment_menu()
the delete there has weight of 20, and the local_tasks.yml had 10. Let's see what it should be.
Comment #5
YesCT CreditAttribution: YesCT commentedbeing done in #2102125: Big Local Task Conversion
Comment #5.0
YesCT CreditAttribution: YesCT commentedanother issue where naming was confusing